Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5408)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2 (Closed)
Patch Set: Fix comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
index b20157e3917d9e159c2c6dcab82ccfb7bbe3b7cc..76f1f0232f5d7a27eb6d82c78a60e3914ddb2d36 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
@@ -760,7 +760,7 @@ void FileManagerPrivateSearchDriveFunction::OnEntryDefinitionList(
std::unique_ptr<SearchResultInfoList> search_result_info_list,
std::unique_ptr<EntryDefinitionList> entry_definition_list) {
DCHECK_EQ(search_result_info_list->size(), entry_definition_list->size());
- base::ListValue* entries = new base::ListValue();
+ auto entries = base::MakeUnique<base::ListValue>();
// Convert Drive files to something File API stack can understand.
for (EntryDefinitionList::const_iterator it = entry_definition_list->begin();
@@ -775,7 +775,7 @@ void FileManagerPrivateSearchDriveFunction::OnEntryDefinitionList(
}
std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue());
- result->Set("entries", entries);
+ result->Set("entries", std::move(entries));
result->SetString("nextFeed", next_link.spec());
SetResult(std::move(result));
@@ -869,7 +869,7 @@ void FileManagerPrivateSearchDriveMetadataFunction::OnEntryDefinitionList(
auto result_dict = base::MakeUnique<base::DictionaryValue>();
// FileEntry fields.
- base::DictionaryValue* entry = new base::DictionaryValue();
+ auto entry = base::MakeUnique<base::DictionaryValue>();
entry->SetString(
"fileSystemName", entry_definition_list->at(i).file_system_name);
entry->SetString(
@@ -880,7 +880,7 @@ void FileManagerPrivateSearchDriveMetadataFunction::OnEntryDefinitionList(
entry->SetBoolean("fileIsDirectory",
entry_definition_list->at(i).is_directory);
- result_dict->Set("entry", entry);
+ result_dict->Set("entry", std::move(entry));
result_dict->SetString(
"highlightedBaseName",
search_result_info_list->at(i).highlighted_base_name);
« no previous file with comments | « chrome/browser/chromeos/extensions/external_cache_unittest.cc ('k') | chrome/browser/chromeos/extensions/info_private_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698