Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4206)

Unified Diff: chrome/browser/chromeos/extensions/info_private_api.h

Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2 (Closed)
Patch Set: Fix comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/info_private_api.h
diff --git a/chrome/browser/chromeos/extensions/info_private_api.h b/chrome/browser/chromeos/extensions/info_private_api.h
index c7e497aec352e2488b4feca956218404e8d81290..9ea71b5fa54c07cc60622f37dd6d6f54822df1b4 100644
--- a/chrome/browser/chromeos/extensions/info_private_api.h
+++ b/chrome/browser/chromeos/extensions/info_private_api.h
@@ -27,7 +27,7 @@ class ChromeosInfoPrivateGetFunction : public AsyncExtensionFunction {
private:
// Returns a newly allocate value, or null.
- base::Value* GetValue(const std::string& property_name);
+ std::unique_ptr<base::Value> GetValue(const std::string& property_name);
// Gets boolean |pref| value from PrefService.
bool GetBooleanPrefValue(const char* pref);

Powered by Google App Engine
This is Rietveld 408576698