Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2765323002: [deoptimizer] Fill the single precision registers in the deoptimizer entry stub. (Closed)

Created:
3 years, 9 months ago by Jarin
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Fill the single precision registers in the deoptimizer entry stub. BUG=v8:6077 Review-Url: https://codereview.chromium.org/2765323002 Cr-Commit-Position: refs/heads/master@{#44035} Committed: https://chromium.googlesource.com/v8/v8/+/798ffc9d67e25a0aa9b0be145892c27f2ac5391f

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -21 lines) Patch
M src/arm/deoptimizer-arm.cc View 4 chunks +21 lines, -2 lines 1 comment Download
M src/arm64/deoptimizer-arm64.cc View 4 chunks +35 lines, -15 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 2 chunks +19 lines, -2 lines 0 comments Download
M src/register-configuration.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 3 chunks +22 lines, -2 lines 0 comments Download
A test/mjsunit/compiler/regress-v8-6077.js View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Jarin
Could you take a look, please?
3 years, 9 months ago (2017-03-22 16:01:34 UTC) #6
Michael Starzinger
LGTM. Thanks!
3 years, 9 months ago (2017-03-22 16:53:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2765323002/1
3 years, 9 months ago (2017-03-22 16:54:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/798ffc9d67e25a0aa9b0be145892c27f2ac5391f
3 years, 9 months ago (2017-03-22 16:56:10 UTC) #14
bbudge
3 years, 9 months ago (2017-03-22 17:08:02 UTC) #16
Message was sent while issue was closed.
Drive by comment. Thanks for fixing this!

https://codereview.chromium.org/2765323002/diff/1/src/arm/deoptimizer-arm.cc
File src/arm/deoptimizer-arm.cc (right):

https://codereview.chromium.org/2765323002/diff/1/src/arm/deoptimizer-arm.cc#...
src/arm/deoptimizer-arm.cc:144: // Push registers s0-s15, and possibly s16-s31,
on the stack.
I think all ARM targets have 32 single precision registers.

Powered by Google App Engine
This is Rietveld 408576698