Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2764913003: Reland of Android: Add APK patch size estimates to resource_sizes.py. (Closed)

Created:
3 years, 9 months ago by estevenson
Modified:
3 years, 9 months ago
Reviewers:
agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Android: Add APK patch size estimates to resource_sizes.py. Original issue: https://codereview.chromium.org/2757293002 Reason for reland: Updated arg names properly. APK patch size estimates will be used on certain perf builders, and will track estimated patch size based on a reference APK (built by the same builder) for the current milestone. BUG=695188 Review-Url: https://codereview.chromium.org/2764913003 Cr-Commit-Position: refs/heads/master@{#458488} Committed: https://chromium.googlesource.com/chromium/src/+/0700eafcdc29d804767a7eeb5f20e7abd87fbb00

Patch Set 1 #

Patch Set 2 : Fix arg names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -74 lines) Patch
A build/android/binary_size/__init__.py View 1 chunk +3 lines, -0 lines 0 comments Download
A + build/android/binary_size/apk_downloader.py View 2 chunks +4 lines, -0 lines 0 comments Download
A build/android/binary_size/apks/README.md View 1 chunk +24 lines, -0 lines 0 comments Download
D build/android/binary_size/update_apks.py View 1 chunk +0 lines, -71 lines 0 comments Download
M build/android/resource_sizes.py View 1 6 chunks +40 lines, -0 lines 0 comments Download
M third_party/apk-patch-size-estimator/README.chromium View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/apk-patch-size-estimator/apk_patch_size_estimator.py View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
estevenson
ptal Andrew
3 years, 9 months ago (2017-03-21 16:52:24 UTC) #2
agrieve
On 2017/03/21 16:52:24, estevenson wrote: > ptal Andrew lgtm
3 years, 9 months ago (2017-03-21 17:13:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764913003/20001
3 years, 9 months ago (2017-03-21 17:25:24 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 18:42:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0700eafcdc29d804767a7eeb5f20...

Powered by Google App Engine
This is Rietveld 408576698