Add optional --no-static-initializer-check to resource_sizes.py

Add optional --no-static-initializer-check to resource_sizes.py

Convenient when running it locally and you want it to be fast, but you
don't want to disable via --no-output-dir so that it still looks at .pak
files.

Review-Url: https://codereview.chromium.org/2764913002
Cr-Commit-Position: refs/heads/master@{#459115}
Committed: https://chromium.googlesource.com/chromium/src/+/6935a6b5c4cac7b654a002b7c80c133d458bfe39

[agrieve, 2017-03-22 15:40:50]

Description was changed from

==========
Add optional --no-static-initializer-check to resource_sizes.py

Convenient when running it locally and you want it to be fast, but you
don't want to disable via --no-output-dir so that it still looks at .pak
files.
==========

to

==========
Add optional --no-static-initializer-check to resource_sizes.py

Convenient when running it locally and you want it to be fast, but you
don't want to disable via --no-output-dir so that it still looks at .pak
files.
==========

[agrieve, 2017-03-22 15:40:50]

agrieve@chromium.org changed reviewers:
+ estevenson@chromium.org

[agrieve, 2017-03-22 15:41:06]

On 2017/03/22 15:40:50, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:estevenson@chromium.org

🗿

[jbudorick, 2017-03-22 15:59:36]

jbudorick@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2017-03-22 15:59:36]

lgtm w/ nit

https://codereview.chromium.org/2764913002/diff/1/build/android/resource_size...
File build/android/resource_sizes.py (right):

https://codereview.chromium.org/2764913002/diff/1/build/android/resource_size...
build/android/resource_sizes.py:777: if not args.no_static_initializer_check:
nit: this may be easier to read if the variable is static_initializer_check,
with it defaulting to true and --no-static-intitializer-check setting it to
false.

[agrieve, 2017-03-23 14:43:23]

https://codereview.chromium.org/2764913002/diff/1/build/android/resource_size...
File build/android/resource_sizes.py (right):

https://codereview.chromium.org/2764913002/diff/1/build/android/resource_size...
build/android/resource_sizes.py:777: if not args.no_static_initializer_check:
On 2017/03/22 15:59:36, jbudorick wrote:
> nit: this may be easier to read if the variable is static_initializer_check,
> with it defaulting to true and --no-static-intitializer-check setting it to
> false.

Done.

[agrieve, 2017-03-23 14:43:27]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2017-03-23 14:43:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2764913002/#ps20001
(title: "remove double negative in flag variable usage")

[commit-bot: I haz the power, 2017-03-23 14:43:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 16:40:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490280207384210,
"parent_rev": "09bbc93b1d355cf7629618c5350219547d6dfbe3", "commit_rev":
"6935a6b5c4cac7b654a002b7c80c133d458bfe39"}

[commit-bot: I haz the power, 2017-03-23 16:40:48]

Description was changed from

==========
Add optional --no-static-initializer-check to resource_sizes.py

Convenient when running it locally and you want it to be fast, but you
don't want to disable via --no-output-dir so that it still looks at .pak
files.
==========

to

==========
Add optional --no-static-initializer-check to resource_sizes.py

Convenient when running it locally and you want it to be fast, but you
don't want to disable via --no-output-dir so that it still looks at .pak
files.

Review-Url: https://codereview.chromium.org/2764913002
Cr-Commit-Position: refs/heads/master@{#459115}
Committed:
https://chromium.googlesource.com/chromium/src/+/6935a6b5c4cac7b654a002b7c80c...
==========

[commit-bot: I haz the power, 2017-03-23 16:40:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6935a6b5c4cac7b654a002b7c80c...