Add optional --no-static-initializer-check to resource_sizes.py

build/android/resource_sizes.py

 #!/usr/bin/python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Prints the size of each given file and optionally computes the size of
    libchrome.so without the dependencies added for building with android NDK.
    Also breaks down the contents of the APK to determine the installed size
    and assign size contributions to different classes of file.
 """
@@ skipping 718 matching lines @@
                          help='Minimum byte size of displayed pak resources.')
   argparser.add_argument('--chromium-output-directory',
                          help='Location of the build artifacts.')
   argparser.add_argument('--chartjson', action='store_true',
                          help='Sets output mode to chartjson.')
   argparser.add_argument('--output-dir', default='.',
                          help='Directory to save chartjson to.')
   argparser.add_argument('--no-output-dir', action='store_true',
                          help='Skip all measurements that rely on having '
                          'output-dir')
+  argparser.add_argument('--no-static-initializer-check', action='store_true',
+                         help='Skip checking for static initializers')
   argparser.add_argument('-d', '--device',
                          help='Dummy option for perf runner.')
   argparser.add_argument('--estimate-patch-size', action='store_true',
                          help='Include patch size estimates. Useful for perf '
                          'builders where a reference APK is available but adds '
                          '~3 mins to run time.')
   argparser.add_argument('--reference-apk-builder',
                          default=apk_downloader.DEFAULT_BUILDER,
                          help='Builder name to use for reference APK for patch '
                          'size estimates.')
@@ skipping 16 matching lines @@
   else:
     tools_prefix = ''
 
   PrintApkAnalysis(args.apk, tools_prefix, chartjson=chartjson)
   _PrintDexAnalysis(args.apk, chartjson=chartjson)
   if args.estimate_patch_size:
     _PrintPatchSizeEstimate(
         args.apk, args.builder, args.bucket, chartjson=chartjson)
   if not args.no_output_dir:
     PrintPakAnalysis(args.apk, args.min_pak_resource_size)
-    _PrintStaticInitializersCountFromApk(
-        args.apk, tools_prefix, chartjson=chartjson)
+    if not args.no_static_initializer_check:

[jbudorick, 2017/03/22 15:59:36]

nit: this may be easier to read if the variable is static_initializer_check,
with it defaulting to true and --no-static-intitializer-check setting it to
false.

[agrieve, 2017/03/23 14:43:23]

Done.

+      _PrintStaticInitializersCountFromApk(
+          args.apk, tools_prefix, chartjson=chartjson)
   if chartjson:
     results_path = os.path.join(args.output_dir, 'results-chart.json')
     logging.critical('Dumping json to %s', results_path)
     with open(results_path, 'w') as json_file:
       json.dump(chartjson, json_file)
 
 
 if __name__ == '__main__':
   sys.exit(main())