No default value for AncestorSearchConstraint in locateFlowThreadContainingBlockOf().

No default value for AncestorSearchConstraint in locateFlowThreadContainingBlockOf().

The default used to be to bail out and return nullptr if it encountered
something unbreakable. It's better to let callers make a conscious choice here.
Tree-read operations (painting or hit testing, for instance) that call
LayoutObject::locateFlowThreadContainingBlock() are typically interested in
converting from flow thread coordinates to visual coordinates.

This is a defensive CL that only reverts unintended and bad changes from
https://codereview.chromium.org/2748973002 - added a TODO for cases where we
have LayoutState; if we are inside of layout, we should ideally stop at
strictly unbreakable ancestors.

BUG=702978
Review-Url: https://codereview.chromium.org/2764883004
Cr-Commit-Position: refs/heads/master@{#458784}
Committed: https://chromium.googlesource.com/chromium/src/+/f41660904d869f6d30fa31f75ca6d6072202d9a1

[mstensho (USE GERRIT), 2017-03-22 09:41:34]

The CQ bit was checked by mstensho@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 09:41:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 11:21:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 11:21:29]

Dry run: This issue passed the CQ dry run.

[mstensho (USE GERRIT), 2017-03-22 14:06:44]

mstensho@opera.com changed reviewers:
+ eae@chromium.org

[eae, 2017-03-22 16:55:43]

LGTM

[eae, 2017-03-22 16:55:46]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-03-22 16:56:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 17:01:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490201746829510, "parent_rev":
"a4a8efbb8b68c2a61636fc469943ecb1d09bd84b", "commit_rev":
"f41660904d869f6d30fa31f75ca6d6072202d9a1"}

[commit-bot: I haz the power, 2017-03-22 17:09:40]

Description was changed from

==========
No default value for AncestorSearchConstraint in
locateFlowThreadContainingBlockOf().

The default used to be to bail out and return nullptr if it encountered
something unbreakable. It's better to let callers make a conscious choice here.
Tree-read operations (painting or hit testing, for instance) that call
LayoutObject::locateFlowThreadContainingBlock() are typically interested in
converting from flow thread coordinates to visual coordinates.

This is a defensive CL that only reverts unintended and bad changes from
https://codereview.chromium.org/2748973002 - added a TODO for cases where we
have LayoutState; if we are inside of layout, we should ideally stop at
strictly unbreakable ancestors.

BUG=702978
==========

to

==========
No default value for AncestorSearchConstraint in
locateFlowThreadContainingBlockOf().

The default used to be to bail out and return nullptr if it encountered
something unbreakable. It's better to let callers make a conscious choice here.
Tree-read operations (painting or hit testing, for instance) that call
LayoutObject::locateFlowThreadContainingBlock() are typically interested in
converting from flow thread coordinates to visual coordinates.

This is a defensive CL that only reverts unintended and bad changes from
https://codereview.chromium.org/2748973002 - added a TODO for cases where we
have LayoutState; if we are inside of layout, we should ideally stop at
strictly unbreakable ancestors.

BUG=702978

Review-Url: https://codereview.chromium.org/2764883004
Cr-Commit-Position: refs/heads/master@{#458784}
Committed:
https://chromium.googlesource.com/chromium/src/+/f41660904d869f6d30fa31f75ca6...
==========

[commit-bot: I haz the power, 2017-03-22 17:09:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f41660904d869f6d30fa31f75ca6...