Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 2748973002: Strictly unbreakable objects need to prevent interaction with the outside. (Closed)

Created:
3 years, 9 months ago by mstensho (USE GERRIT)
Modified:
3 years, 9 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Strictly unbreakable objects need to prevent interaction with the outside. A strictly unbreakable object (i.e. when getPaginationBreakability() == ForbidBreaks) has no valid break points inside. This is the case for e.g. images, writing mode roots and scrollable objects. If such an object is in the containing block chain between two nested multicol containers, column content in multicol containers on the inside shouldn't interact with columns in the enclosing multicol container. BUG=698686 Review-Url: https://codereview.chromium.org/2748973002 Cr-Commit-Position: refs/heads/master@{#457177} Committed: https://chromium.googlesource.com/chromium/src/+/bfc4d20f79563dd15832c9f77a4cb916476f3b7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -24 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/nested-inside-unbreakable-crash.html View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlowThread.h View 1 chunk +17 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp View 2 chunks +11 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h View 1 chunk +2 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mstensho (USE GERRIT)
3 years, 9 months ago (2017-03-14 13:16:24 UTC) #6
eae
LGTM
3 years, 9 months ago (2017-03-15 17:05:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2748973002/1
3 years, 9 months ago (2017-03-15 17:06:08 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 19:59:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bfc4d20f79563dd15832c9f77a4c...

Powered by Google App Engine
This is Rietveld 408576698