Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2764783004: Add DocumentMarker::createTextMatchMarker() (Closed)

Created:
3 years, 9 months ago by rlanday
Modified:
3 years, 8 months ago
Reviewers:
*yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DocumentMarker::createTextMatchMarker() DocumentMarkerController refactor part 4: replace DocumentMarker's TextMatch-specific constructor with a clearly-named createTextMatchMarker() method. Similar CL(s) for Spelling and Grammar marker types to follow. Depends on https://codereview.chromium.org/2766003002 BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Upload properly #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -47 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 1 2 3 11 chunks +13 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarker.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp View 2 2 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 25 (19 generated)
rlanday
3 years, 9 months ago (2017-03-21 22:47:27 UTC) #4
yosin_UTC9
Is this all-on-patch instead of just introducing createTextMatchMarker()?
3 years, 9 months ago (2017-03-22 05:17:01 UTC) #13
rlanday
On 2017/03/22 at 05:17:01, yosin wrote: > Is this all-on-patch instead of just introducing createTextMatchMarker()? ...
3 years, 9 months ago (2017-03-22 17:20:46 UTC) #14
yosin_UTC9
lgtm BTW, we want to change |bool| parameter of |createTextMatchmarker()| later.
3 years, 9 months ago (2017-03-24 01:57:02 UTC) #23
rlanday
On 2017/03/24 at 01:57:02, yosin wrote: > lgtm > > BTW, we want to change ...
3 years, 8 months ago (2017-03-29 01:55:04 UTC) #24
rlanday
3 years, 8 months ago (2017-03-29 23:14:58 UTC) #25

Powered by Google App Engine
This is Rietveld 408576698