Change WebFrameImplBase::initializeCoreFrame to take a Page&

Change WebFrameImplBase::initializeCoreFrame to take a Page&

Now that Frame stores a Page, this just updates the initializeCoreFrame
method to take a Page&, since it can't be null. This is pre-work to
remove FrameHost.


BUG=688614
Review-Url: https://codereview.chromium.org/2764773003
Cr-Commit-Position: refs/heads/master@{#459712}
Committed: https://chromium.googlesource.com/chromium/src/+/2fc2a13e89b06fe9e65591b79edfa5cf6dab2b87

[sashab, 2017-03-22 00:41:36]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[sashab, 2017-03-22 00:41:47]

sashab@chromium.org changed reviewers:
+ joelhockey@chromium.org

[commit-bot: I haz the power, 2017-03-22 00:42:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-03-22 00:45:34]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2017-03-22 00:45:35]

Drive-by: since we're changing this, can we pass as a mutable ref to indicate
that this should not be null?

[sashab, 2017-03-22 00:53:40]

Sure. Should the Frame constructors take a mutable ref as well? (Will do this in
follow-up patch if so)

[dcheng, 2017-03-22 00:56:38]

On 2017/03/22 00:53:40, sashab wrote:
> Sure. Should the Frame constructors take a mutable ref as well? (Will do this
in
> follow-up patch if so)

Yeah, they should be taking a mutable ref as well. Thanks!

[sashab, 2017-03-22 00:56:53]

Description was changed from

==========
Change WebFrameImplBase::initializeCoreFrame to take a Page

Now that Frame stores a Page, this just updates the initializeCoreFrame
method to take a Page. This is pre-work to remove FrameHost.

BUG=688614
==========

to

==========
Change WebFrameImplBase::initializeCoreFrame to take a Page&

Now that Frame stores a Page, this just updates the initializeCoreFrame
method to take a Page&, since it can't be null. This is pre-work to
remove FrameHost.


BUG=688614
==========

[sashab, 2017-03-22 00:57:36]

Done, ptal joel or daniel :)

[dcheng, 2017-03-22 00:58:25]

(also, the current patch lgtm)

[sashab, 2017-03-22 00:58:36]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2017-03-22 00:59:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joelhockey, 2017-03-22 02:19:01]

lgtm

[commit-bot: I haz the power, 2017-03-22 03:01:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 03:01:22]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT,
build hasn't started yet, builder probably lacks capacity)

[sashab, 2017-03-22 03:08:23]

The CQ bit was checked by sashab@chromium.org

[sashab, 2017-03-22 03:08:23]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2017-03-22 03:09:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 05:10:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 05:10:26]

Exceeded global retry quota

[sashab, 2017-03-22 05:35:32]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2017-03-22 05:35:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 05:41:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 05:41:38]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sashab, 2017-03-23 23:30:38]

The CQ bit was checked by sashab@chromium.org

[sashab, 2017-03-23 23:30:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
joelhockey@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2764773003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-23 23:31:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 00:42:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 00:42:08]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sashab, 2017-03-24 00:45:06]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2017-03-24 00:45:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 01:54:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 01:54:49]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sashab, 2017-03-24 01:56:31]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2017-03-24 01:56:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 03:48:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 03:48:52]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sashab, 2017-03-24 04:56:15]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2017-03-24 04:56:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 06:39:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 06:39:13]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sashab, 2017-03-27 05:15:07]

The CQ bit was checked by sashab@chromium.org

[sashab, 2017-03-27 05:15:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
joelhockey@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2764773003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-27 05:15:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 07:03:08]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490591707250820,
"parent_rev": "43d60fabe17ef7d4c63680b49d30b9072b31bb67", "commit_rev":
"2fc2a13e89b06fe9e65591b79edfa5cf6dab2b87"}

[commit-bot: I haz the power, 2017-03-27 07:04:17]

Description was changed from

==========
Change WebFrameImplBase::initializeCoreFrame to take a Page&

Now that Frame stores a Page, this just updates the initializeCoreFrame
method to take a Page&, since it can't be null. This is pre-work to
remove FrameHost.


BUG=688614
==========

to

==========
Change WebFrameImplBase::initializeCoreFrame to take a Page&

Now that Frame stores a Page, this just updates the initializeCoreFrame
method to take a Page&, since it can't be null. This is pre-work to
remove FrameHost.


BUG=688614

Review-Url: https://codereview.chromium.org/2764773003
Cr-Commit-Position: refs/heads/master@{#459712}
Committed:
https://chromium.googlesource.com/chromium/src/+/2fc2a13e89b06fe9e65591b79edf...
==========

[commit-bot: I haz the power, 2017-03-27 07:04:18]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2fc2a13e89b06fe9e65591b79edf...