Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2764703004: Reland of Only release the pointer lock when the RenderWidgetHost being destroyed (Closed)

Created:
3 years, 9 months ago by lfg
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Only release the pointer lock when the RenderWidgetHost being destroyed (patchset #1 id:1 of https://codereview.chromium.org/2763953003/ ) Reason for revert: Relanding with the test disabled on Mac. Original issue's description: > Revert of Only release the pointer lock when the RenderWidgetHost being destroyed (patchset #1 id:1 of https://codereview.chromium.org/2760343002/ ) > > Reason for revert: > Looks like this breaks PointerLockBrowserTest.PointerLockChildFrameDetached: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/28142 > > Original issue's description: > > Only release the pointer lock when the RenderWidgetHost being destroyed > > is the one holding the pointer lock. > > > > This fixes a crash where the WebContents would stop tracking which > > RenderWidgetHost was holding the pointer lock. > > > > BUG=703284 > > > > Review-Url: https://codereview.chromium.org/2760343002 > > Cr-Commit-Position: refs/heads/master@{#458446} > > Committed: https://chromium.googlesource.com/chromium/src/+/bf846a94da5c2b4f8ff93a7942d3d50799381675 > > TBR=creis@chromium.org,alexmos@chromium.org,lfg@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=703284 > > Review-Url: https://codereview.chromium.org/2763953003 > Cr-Commit-Position: refs/heads/master@{#458539} > Committed: https://chromium.googlesource.com/chromium/src/+/a2fda5591832a96af3146f6a3db8cb9b947c2a86 TBR=creis@chromium.org,alexmos@chromium.org,dgozman@chromium.org BUG=703284 Review-Url: https://codereview.chromium.org/2764703004 Cr-Commit-Position: refs/heads/master@{#458692} Committed: https://chromium.googlesource.com/chromium/src/+/7d4caadfaa86b424f3c2459563aa5a369f468976

Patch Set 1 #

Patch Set 2 : disable test on mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M content/browser/pointer_lock_browsertest.cc View 1 1 chunk +43 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (12 generated)
lfg
Created Reland of Only release the pointer lock when the RenderWidgetHost being destroyed
3 years, 9 months ago (2017-03-21 21:06:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764703004/70001
3 years, 9 months ago (2017-03-22 08:53:49 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 09:07:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:70001) as
https://chromium.googlesource.com/chromium/src/+/7d4caadfaa86b424f3c2459563aa...

Powered by Google App Engine
This is Rietveld 408576698