Only release the pointer lock when the RenderWidgetHost being destroyed

Only release the pointer lock when the RenderWidgetHost being destroyed
is the one holding the pointer lock.

This fixes a crash where the WebContents would stop tracking which
RenderWidgetHost was holding the pointer lock.

BUG=703284
Review-Url: https://codereview.chromium.org/2760343002
Cr-Commit-Position: refs/heads/master@{#458446}
Committed: https://chromium.googlesource.com/chromium/src/+/bf846a94da5c2b4f8ff93a7942d3d50799381675

[lfg, 2017-03-21 14:59:43]

lfg@chromium.org changed reviewers:
+ creis@chromium.org

[lfg, 2017-03-21 14:59:44]

Charlie, please take a look.

[lfg, 2017-03-21 15:37:10]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 15:37:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 16:36:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 16:36:14]

Dry run: This issue passed the CQ dry run.

[alexmos, 2017-03-21 16:47:24]

alexmos@chromium.org changed reviewers:
+ alexmos@chromium.org

[alexmos, 2017-03-21 16:47:24]

LGTM

[lfg, 2017-03-21 16:48:06]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2017-03-21 16:48:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 17:08:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490114886461250, "parent_rev":
"8f33a0e4e0cc8deb3564853fbdd4904aeabf940d", "commit_rev":
"bf846a94da5c2b4f8ff93a7942d3d50799381675"}

[commit-bot: I haz the power, 2017-03-21 17:09:37]

Description was changed from

==========
Only release the pointer lock when the RenderWidgetHost being destroyed
is the one holding the pointer lock.

This fixes a crash where the WebContents would stop tracking which
RenderWidgetHost was holding the pointer lock.

BUG=703284
==========

to

==========
Only release the pointer lock when the RenderWidgetHost being destroyed
is the one holding the pointer lock.

This fixes a crash where the WebContents would stop tracking which
RenderWidgetHost was holding the pointer lock.

BUG=703284

Review-Url: https://codereview.chromium.org/2760343002
Cr-Commit-Position: refs/heads/master@{#458446}
Committed:
https://chromium.googlesource.com/chromium/src/+/bf846a94da5c2b4f8ff93a7942d3...
==========

[commit-bot: I haz the power, 2017-03-21 17:09:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bf846a94da5c2b4f8ff93a7942d3...

[dgozman, 2017-03-21 20:47:21]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2763953003/ by dgozman@chromium.org.

The reason for reverting is: Looks like this breaks
PointerLockBrowserTest.PointerLockChildFrameDetached:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%20....

[lfg, 2017-03-21 21:03:41]

On 2017/03/21 20:47:21, dgozman wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2763953003/ by mailto:dgozman@chromium.org.
> 
> The reason for reverting is: Looks like this breaks
> PointerLockBrowserTest.PointerLockChildFrameDetached:
>
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%20....

It doesn't break the test, the test was added in this CL.

This seems to be an issue with the lifetime of the RenderWidgetHostViewMac, see
the comment here:
https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_wid....

For now, I'll reland this with the test disabled on Mac, as the change fixes the
#2 browser crash we have.