Use xvfb for the ozone linux tests

Use xvfb for the ozone linux tests

This is needed to fix
linux_chromium_ozone_compile_only_ng to run tests with x11

BUG=666958
Review-Url: https://codereview.chromium.org/2764483002
Cr-Commit-Position: refs/heads/master@{#458349}
Committed: https://chromium.googlesource.com/chromium/src/+/aea527346d04c035ab38f14e0c3df0647c32230d

[msisov, 2017-03-20 14:50:21]

Description was changed from

==========
Test

BUG=
==========

to

==========
Test

BUG=
==========

[msisov, 2017-03-20 15:05:27]

Patchset #1 (id:1) has been deleted

[msisov, 2017-03-20 15:07:20]

Description was changed from

==========
Test

BUG=
==========

to

==========
Use xvfb for the ozone linux tests
==========

[msisov, 2017-03-20 15:07:20]

msisov@igalia.com changed reviewers:
+ dpranke@chromium.org

[msisov, 2017-03-20 15:08:32]

Description was changed from

==========
Use xvfb for the ozone linux tests
==========

to

==========
Use xvfb for the ozone linux tests

this is needed to fix
linux_chromium_ozone_compile_only_ng to run tests with x11
==========

[msisov, 2017-03-20 15:08:39]

ptal

[fwang, 2017-03-20 15:10:34]

fwang@igalia.com changed reviewers:
+ fwang@igalia.com

[fwang, 2017-03-20 15:10:35]

https://codereview.chromium.org/2764483002/diff/20001/tools/mb/mb.py
File tools/mb/mb.py (right):

https://codereview.chromium.org/2764483002/diff/20001/tools/mb/mb.py#newcode1069
tools/mb/mb.py:1069: not android and ozone or (ozone and chromeos))
I think ((not ozone) or (ozone and chromeos)) can just be removed

[kylechar, 2017-03-20 17:03:31]

kylechar@chromium.org changed reviewers:
+ kylechar@chromium.org

[kylechar, 2017-03-20 17:03:31]

https://codereview.chromium.org/2764483002/diff/20001/tools/mb/mb.py
File tools/mb/mb.py (right):

https://codereview.chromium.org/2764483002/diff/20001/tools/mb/mb.py#newcode1069
tools/mb/mb.py:1069: not android and ozone or (ozone and chromeos))
On 2017/03/20 15:10:35, fwang wrote:
> I think ((not ozone) or (ozone and chromeos)) can just be removed

Yep, like this:

use_xvfb = (self.platform == 'linux2' and
           not android)

[Dirk Pranke, 2017-03-20 17:22:50]

https://codereview.chromium.org/2764483002/diff/20001/tools/mb/mb.py
File tools/mb/mb.py (right):

https://codereview.chromium.org/2764483002/diff/20001/tools/mb/mb.py#newcode1069
tools/mb/mb.py:1069: not android and ozone or (ozone and chromeos))
On 2017/03/20 17:03:31, kylechar wrote:
> On 2017/03/20 15:10:35, fwang wrote:
> > I think ((not ozone) or (ozone and chromeos)) can just be removed
> 
> Yep, like this:
> 
> use_xvfb = (self.platform == 'linux2' and
>            not android)

So there's no non-X11 configuration we're testing any more? Or will the
configurations that don't use X11 just ignore the fact that they're running
under xvfb?

[kylechar, 2017-03-20 17:30:42]

https://codereview.chromium.org/2764483002/diff/20001/tools/mb/mb.py
File tools/mb/mb.py (right):

https://codereview.chromium.org/2764483002/diff/20001/tools/mb/mb.py#newcode1069
tools/mb/mb.py:1069: not android and ozone or (ozone and chromeos))
On 2017/03/20 17:22:50, Dirk Pranke wrote:
> On 2017/03/20 17:03:31, kylechar wrote:
> > On 2017/03/20 15:10:35, fwang wrote:
> > > I think ((not ozone) or (ozone and chromeos)) can just be removed
> > 
> > Yep, like this:
> > 
> > use_xvfb = (self.platform == 'linux2' and
> >            not android)
> 
> So there's no non-X11 configuration we're testing any more? Or will the
> configurations that don't use X11 just ignore the fact that they're running
> under xvfb?

This particular change only affects 'Ozone Linux' FYI bot, which runs two tests
with Ozone X11 now (and previously ran 0 tests total).

In general, the Ozone CrOS trybot runs a couple of tests with Ozone headless
still. If type=window_test_launcher then it will run using Xvfb. The tests
wouldn't check $DISPLAY env var and wouldn't know Xvfb was running though..

[Dirk Pranke, 2017-03-20 17:36:58]

lgtm.

https://codereview.chromium.org/2764483002/diff/20001/tools/mb/mb.py
File tools/mb/mb.py (right):

https://codereview.chromium.org/2764483002/diff/20001/tools/mb/mb.py#newcode1069
tools/mb/mb.py:1069: not android and ozone or (ozone and chromeos))
I guess we were already assuming CrOS+Ozone==X11. Using X11 for things we know
are using Ozone still feels weird to me :).

Can we update the comments on lines 1065-1067 to make this clearer somehow?

[fwang, 2017-03-21 06:54:29]

https://codereview.chromium.org/2764483002/diff/20001/tools/mb/mb.py
File tools/mb/mb.py (right):

https://codereview.chromium.org/2764483002/diff/20001/tools/mb/mb.py#newcode1069
tools/mb/mb.py:1069: not android and ozone or (ozone and chromeos))
On 2017/03/20 17:36:57, Dirk Pranke wrote:
> Can we update the comments on lines 1065-1067 to make this clearer somehow?

What about this:

"... For example, Linux Desktop, X11 CrOS and Ozone builds. Note that one Ozone
build can be used to run different backends. Currently, tests are executed for
the headless and X11 backends and both can run under Xvfb.
FIXME(tonikitoo,msisov,fwang): Find a way to run tests for the Wayland backend."

[msisov, 2017-03-21 07:01:00]

The CQ bit was checked by msisov@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 07:01:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msisov, 2017-03-21 07:02:36]

Description was changed from

==========
Use xvfb for the ozone linux tests

this is needed to fix
linux_chromium_ozone_compile_only_ng to run tests with x11
==========

to

==========
Use xvfb for the ozone linux tests

This is needed to fix
linux_chromium_ozone_compile_only_ng to run tests with x11

BUG=
==========

[msisov, 2017-03-21 07:03:04]

Description was changed from

==========
Use xvfb for the ozone linux tests

This is needed to fix
linux_chromium_ozone_compile_only_ng to run tests with x11

BUG=
==========

to

==========
Use xvfb for the ozone linux tests

This is needed to fix
linux_chromium_ozone_compile_only_ng to run tests with x11

BUG=666958
==========

[msisov, 2017-03-21 07:18:16]

https://codereview.chromium.org/2764483002/diff/20001/tools/mb/mb.py
File tools/mb/mb.py (right):

https://codereview.chromium.org/2764483002/diff/20001/tools/mb/mb.py#newcode1069
tools/mb/mb.py:1069: not android and ozone or (ozone and chromeos))
On 2017/03/21 06:54:29, fwang wrote:
> On 2017/03/20 17:36:57, Dirk Pranke wrote:
> > Can we update the comments on lines 1065-1067 to make this clearer somehow?
> 
> What about this:
> 
> "... For example, Linux Desktop, X11 CrOS and Ozone builds. Note that one
Ozone
> build can be used to run different backends. Currently, tests are executed for
> the headless and X11 backends and both can run under Xvfb.
> FIXME(tonikitoo,msisov,fwang): Find a way to run tests for the Wayland
backend."

Done.

[commit-bot: I haz the power, 2017-03-21 08:02:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 08:02:42]

Dry run: This issue passed the CQ dry run.

[msisov, 2017-03-21 08:03:51]

The CQ bit was checked by msisov@igalia.com

[msisov, 2017-03-21 08:03:52]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2764483002/#ps40001
(title: "comment")

[commit-bot: I haz the power, 2017-03-21 08:04:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 08:08:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490083431465020,
"parent_rev": "8c762e79eef5c9a6d7bce492ec42e8870ab21f8e", "commit_rev":
"aea527346d04c035ab38f14e0c3df0647c32230d"}

[commit-bot: I haz the power, 2017-03-21 08:09:12]

Description was changed from

==========
Use xvfb for the ozone linux tests

This is needed to fix
linux_chromium_ozone_compile_only_ng to run tests with x11

BUG=666958
==========

to

==========
Use xvfb for the ozone linux tests

This is needed to fix
linux_chromium_ozone_compile_only_ng to run tests with x11

BUG=666958

Review-Url: https://codereview.chromium.org/2764483002
Cr-Commit-Position: refs/heads/master@{#458349}
Committed:
https://chromium.googlesource.com/chromium/src/+/aea527346d04c035ab38f14e0c3d...
==========

[commit-bot: I haz the power, 2017-03-21 08:09:13]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/aea527346d04c035ab38f14e0c3d...