Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: tools/mb/mb.py

Issue 2764483002: Use xvfb for the ozone linux tests (Closed)
Patch Set: comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/mb/mb.py
diff --git a/tools/mb/mb.py b/tools/mb/mb.py
index 917f3c62be301aad351cf8234a38bbb2d46ee84a..7dd3ac0201f9d1b47a4788ae2e2fe8b5428bc5cc 100755
--- a/tools/mb/mb.py
+++ b/tools/mb/mb.py
@@ -1059,15 +1059,16 @@ class MetaBuildWrapper(object):
isolate_map = self.ReadIsolateMap()
android = 'target_os="android"' in vals['gn_args']
- ozone = 'use_ozone=true' in vals['gn_args']
- chromeos = 'target_os="chromeos"' in vals['gn_args']
# This should be true if tests with type='windowed_test_launcher' are
# expected to run using xvfb. For example, Linux Desktop, X11 CrOS and
- # Ozone CrOS builds.
+ # Ozone CrOS builds. Note that one Ozone build can be used to run differen
+ # backends. Currently, tests are executed for the headless and X11 backends
+ # and both can run under Xvfb.
+ # TODO(tonikitoo,msisov,fwang): Find a way to run tests for the Wayland
+ # backend.
use_xvfb = (self.platform == 'linux2' and
- not android and
- ((not ozone) or (ozone and chromeos)))
+ not android)
asan = 'is_asan=true' in vals['gn_args']
msan = 'is_msan=true' in vals['gn_args']
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698