Issue 2764303002: Move throwNoSuchMethodError to BodyBuilder.

Issue 2764303002: Move throwNoSuchMethodError to BodyBuilder. (Closed)

Created:
3 years, 9 months ago by ahe

Modified:
3 years, 9 months ago

Reviewers:
karlklose, Paul Berry

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Move throwNoSuchMethodError to BodyBuilder. R=karlklose@google.com, paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/f12acc02a378fde2ad5fad3e3ffb704861eb9a79

Patch Set 1 #

Total comments: 2

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -66 lines)			Patch
	M	pkg/front_end/lib/src/fasta/kernel/body_builder.dart	View		4 chunks	+24 lines, -8 lines	2 comments	Download
	M	pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart	View		10 chunks	+34 lines, -58 lines	0 comments	Download

Depends on Patchset:

Issue 2767633004 Patch 20001

Dependent Patchsets:

Issue 2770623003 Patch 1

Messages

Total messages: 9 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ahe

https://codereview.chromium.org/2764303002/diff/50001/pkg/front_end/lib/src/fasta/kernel/body_builder.dart File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right): https://codereview.chromium.org/2764303002/diff/50001/pkg/front_end/lib/src/fasta/kernel/body_builder.dart#newcode685 pkg/front_end/lib/src/fasta/kernel/body_builder.dart:685: warning("Getter not found: '$errorName'.", charOffset); Note: before I used ...

3 years, 9 months ago (2017-03-22 12:23:23 UTC) #5

ahe

3 years, 9 months ago (2017-03-23 11:49:50 UTC) #9

Message was sent while issue was closed.

Committed patchset #1 (id:50001) manually as
f12acc02a378fde2ad5fad3e3ffb704861eb9a79 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages