Move throwNoSuchMethodError to BodyBuilder.

pkg/front_end/lib/src/fasta/kernel/body_builder.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.body_builder;
 
 import '../parser/parser.dart' show FormalParameterType, optional;
 
 import '../parser/error_kind.dart' show ErrorKind;
 
@@ skipping 20 matching lines @@
     show JumpTargetKind, NullValue, ScopeListener;
 
 import '../builder/scope.dart' show ProblemBuilder, Scope;
 
 import '../source/outline_builder.dart' show asyncMarkerFromTokens;
 
 import 'builder_accessors.dart';
 
 import 'frontend_accessors.dart' show buildIsNull, makeBinary, makeLet;
 
-import 'builder_accessors.dart' as builder_accessors
-    show throwNoSuchMethodError;
-
 import '../quote.dart'
     show
         Quote,
         analyzeQuote,
         unescape,
         unescapeFirstStringPart,
         unescapeLastStringPart,
         unescapeString;
 
 import '../modifier.dart' show Modifier, constMask, finalMask;
@@ skipping 32 matching lines @@
 
 class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
   final KernelLibraryBuilder library;
 
   final MemberBuilder member;
 
   final KernelClassBuilder classBuilder;
 
   final ClassHierarchy hierarchy;
 
-  @override
   final CoreTypes coreTypes;
 
   final bool isInstanceMember;
 
   final Map<String, FieldInitializer> fieldInitializers =
       <String, FieldInitializer>{};
 
   final Scope enclosingScope;
 
   final bool isDartLibrary;
@@ skipping 566 matching lines @@
     receiver = new SuperPropertyGet(node.name, target);
     return buildMethodInvocation(
         receiver, callName, node.arguments, node.fileOffset);
   }
 
   bool areArgumentsCompatible(FunctionNode function, Arguments arguments) {
     // TODO(ahe): Implement this.
     return true;
   }
 
+  @override
   Expression throwNoSuchMethodError(
       String name, Arguments arguments, int charOffset,
       {bool isSuper: false, isGetter: false, isSetter: false}) {
-    return builder_accessors.throwNoSuchMethodError(
-        name, arguments, uri, charOffset, coreTypes,
-        isSuper: isSuper, isGetter: isGetter, isSetter: isSetter);
+    String errorName = isSuper ? "super.$name" : name;
+    if (isGetter) {
+      warning("Getter not found: '$errorName'.", charOffset);

[ahe, 2017/03/22 12:23:23]

Note: before I used printUnexpected. This would report this as an error (but not
call addCompileTimeError). However, this is only a warning.

+    } else if (isSetter) {
+      warning("Setter not found: '$errorName'.", charOffset);
+    } else {
+      warning("Method not found: '$errorName'.", charOffset);

[ahe, 2017/03/22 12:23:23]

Note: changed to use errorName.

+    }
+    Constructor constructor =
+        coreTypes.getClass("dart:core", "NoSuchMethodError").constructors.first;
+    return new Throw(new ConstructorInvocation(
+        constructor,
+        new Arguments(<Expression>[
+          new NullLiteral(),
+          new SymbolLiteral(name),
+          new ListLiteral(arguments.positional),
+          new MapLiteral(arguments.named.map((arg) {
+            return new MapEntry(new SymbolLiteral(arg.name), arg.value);
+          }).toList()),
+          new NullLiteral()
+        ])));
   }
 
   @override
   Member lookupSuperMember(Name name, {bool isSetter: false}) {
     Class superclass = classBuilder.cls.superclass;
     return superclass == null
         ? null
         : hierarchy.getDispatchTarget(superclass, name, setter: isSetter);
   }
 
@@ skipping 399 matching lines @@
   void handleLiteralBool(Token token) {
     debugEvent("LiteralBool");
     bool value = optional("true", token);
     assert(value || optional("false", token));
     push(new BoolLiteral(value)..fileOffset = token.charOffset);
   }
 
   @override
   void handleLiteralDouble(Token token) {
     debugEvent("LiteralDouble");
-    push(new DoubleLiteral(double.parse(token.lexeme))..fileOffset = token.charOffset);
+    push(new DoubleLiteral(double.parse(token.lexeme))
+      ..fileOffset = token.charOffset);
   }
 
   @override
   void handleLiteralNull(Token token) {
     debugEvent("LiteralNull");
     push(new NullLiteral()..fileOffset = token.charOffset);
   }
 
   @override
   void handleLiteralMap(
@@ skipping 1663 matching lines @@
   } else if (node is PrefixBuilder) {
     return node.name;
   } else if (node is ThisAccessor) {
     return node.isSuper ? "super" : "this";
   } else if (node is BuilderAccessor) {
     return node.plainNameForRead;
   } else {
     return internalError("Unhandled: ${node.runtimeType}");
   }
 }