Report compile-time errors on cyclic hierarchies.

Report compile-time errors on cyclic hierarchies.

R=karlklose@google.com, paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/0087af4e3c3ac7a1aadcfb9d04e4b6f4bcc8e790

[ahe, 2017-03-22 11:46:24]

Patchset #1 (id:1) has been deleted

[ahe, 2017-03-22 11:47:16]

ahe@google.com changed reviewers:
+ karlklose@google.com, paulberry@google.com

[karlklose, 2017-03-22 12:24:41]

LGTM

[Paul Berry, 2017-03-22 16:22:30]

lgtm

https://codereview.chromium.org/2767633004/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/builder/class_builder.dart (right):

https://codereview.chromium.org/2767633004/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/builder/class_builder.dart:200:
library.addNit(charOffset, message, fileUri: fileUri);
Not a blocking issue for this CL, but when we next meet I'd like to understand
what a "nit" is.  We've been hearing reports for quite some time that users are
confused by the subtle distinctions analyzer makes among error, warning, hint,
and lint, and we've been wanting to reduce the number of categories.  Adding a
"nit" category seems like it goes against this goal.

[ahe, 2017-03-22 17:49:49]

https://codereview.chromium.org/2767633004/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/builder/class_builder.dart (right):

https://codereview.chromium.org/2767633004/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/builder/class_builder.dart:200:
library.addNit(charOffset, message, fileUri: fileUri);
On 2017/03/22 16:22:30, Paul Berry wrote:
> Not a blocking issue for this CL, but when we next meet I'd like to understand
> what a "nit" is.  We've been hearing reports for quite some time that users
are
> confused by the subtle distinctions analyzer makes among error, warning, hint,
> and lint, and we've been wanting to reduce the number of categories.  Adding a
> "nit" category seems like it goes against this goal.

I agree. I use "nit" to report warnings that aren't warnings. Perhaps I should
silence them unless using verbose mode.

[ahe, 2017-03-23 11:35:35]

Thank you!

https://codereview.chromium.org/2767633004/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/builder/class_builder.dart (right):

https://codereview.chromium.org/2767633004/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/builder/class_builder.dart:200:
library.addNit(charOffset, message, fileUri: fileUri);
On 2017/03/22 17:49:49, ahe wrote:
> On 2017/03/22 16:22:30, Paul Berry wrote:
> > Not a blocking issue for this CL, but when we next meet I'd like to
understand
> > what a "nit" is.  We've been hearing reports for quite some time that users
> are
> > confused by the subtle distinctions analyzer makes among error, warning,
hint,
> > and lint, and we've been wanting to reduce the number of categories.  Adding
a
> > "nit" category seems like it goes against this goal.
> 
> I agree. I use "nit" to report warnings that aren't warnings. Perhaps I should
> silence them unless using verbose mode.

I did that in CL 2770683005.

[ahe, 2017-03-23 11:41:10]

Description was changed from

==========
Report compile-time errors on cyclic hierarchies.
==========

to

==========
Report compile-time errors on cyclic hierarchies.

R=karlklose@google.com, paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0087af4e3c3ac7a1aadcfb9d04e4b6f4bcc8e790
==========

[ahe, 2017-03-23 11:41:12]

Committed patchset #1 (id:20001) manually as
0087af4e3c3ac7a1aadcfb9d04e4b6f4bcc8e790 (presubmit successful).