Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

Issue 2764023003: Updating :in-range should not rely on validation. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/invalidation/in-range-pseudo.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 564 matching lines...) Expand 10 before | Expand all | Expand 10 after
575 return m_isValid; 575 return m_isValid;
576 } 576 }
577 577
578 void HTMLFormControlElement::setNeedsValidityCheck() { 578 void HTMLFormControlElement::setNeedsValidityCheck() {
579 if (!m_validityIsDirty) { 579 if (!m_validityIsDirty) {
580 m_validityIsDirty = true; 580 m_validityIsDirty = true;
581 formOwnerSetNeedsValidityCheck(); 581 formOwnerSetNeedsValidityCheck();
582 fieldSetAncestorsSetNeedsValidityCheck(parentNode()); 582 fieldSetAncestorsSetNeedsValidityCheck(parentNode());
583 pseudoStateChanged(CSSSelector::PseudoValid); 583 pseudoStateChanged(CSSSelector::PseudoValid);
584 pseudoStateChanged(CSSSelector::PseudoInvalid); 584 pseudoStateChanged(CSSSelector::PseudoInvalid);
585 pseudoStateChanged(CSSSelector::PseudoInRange);
586 pseudoStateChanged(CSSSelector::PseudoOutOfRange);
587 } 585 }
588 586
587 pseudoStateChanged(CSSSelector::PseudoInRange);
588 pseudoStateChanged(CSSSelector::PseudoOutOfRange);
589
589 // Updates only if this control already has a validation message. 590 // Updates only if this control already has a validation message.
590 if (isValidationMessageVisible()) { 591 if (isValidationMessageVisible()) {
591 // Calls updateVisibleValidationMessage() even if m_isValid is not 592 // Calls updateVisibleValidationMessage() even if m_isValid is not
592 // changed because a validation message can be changed. 593 // changed because a validation message can be changed.
593 updateVisibleValidationMessage(); 594 updateVisibleValidationMessage();
594 } 595 }
595 } 596 }
596 597
597 void HTMLFormControlElement::setCustomValidity(const String& error) { 598 void HTMLFormControlElement::setCustomValidity(const String& error) {
598 ListedElement::setCustomValidity(error); 599 ListedElement::setCustomValidity(error);
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
634 const Element& source) { 635 const Element& source) {
635 HTMLElement::copyNonAttributePropertiesFromElement(source); 636 HTMLElement::copyNonAttributePropertiesFromElement(source);
636 setNeedsValidityCheck(); 637 setNeedsValidityCheck();
637 } 638 }
638 639
639 void HTMLFormControlElement::associateWith(HTMLFormElement* form) { 640 void HTMLFormControlElement::associateWith(HTMLFormElement* form) {
640 associateByParser(form); 641 associateByParser(form);
641 }; 642 };
642 643
643 } // namespace blink 644 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/invalidation/in-range-pseudo.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698