DevTools: Do not apply first suggestion in the classes pane on enter

DevTools: Do not apply first suggestion in the classes pane on enter

Now it works like this: http://i.imgur.com/IYk13Yf.gif . 
Which is consistent with the behaviour in the styles pane.

BUG=690255
Review-Url: https://codereview.chromium.org/2764003002
Cr-Commit-Position: refs/heads/master@{#458884}
Committed: https://chromium.googlesource.com/chromium/src/+/2ec06ab81aae16ab444938342c2bf0a6fc712374

[kdzwinel, 2017-03-21 12:27:37]

Description was changed from

==========
Accept but do not apply first autocomplete suggestion in the ClassPaneWidget
when enter is pressed

BUG=690255
==========

to

==========
Accept but do not apply first autocomplete suggestion in the ClassPaneWidget
when enter is pressed

Now it works like this: http://i.imgur.com/IYk13Yf.gif . Which is consistent
with behaviour in the styles pane.

BUG=690255
==========

[kdzwinel, 2017-03-21 12:27:37]

kdzwinel@gmail.com changed reviewers:
+ einbinder@chromium.org, lushnikov@chromium.org

[kdzwinel, 2017-03-21 12:32:38]

PTAL

https://codereview.chromium.org/2764003002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js (right):

https://codereview.chromium.org/2764003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js:493: var
shouldSelect = !this._disableDefaultSuggestionForEmptyInput || !!this.text();
not really related, but I found it while investigating original issue.
`updateSuggestions` expects `shouldSelect` (`selectHighestPriority`) to be a
boolean, before this change it was sometimes a string. BTW: why closure compiler
missed that?

http://i.imgur.com/XFEzuv4.png

[kdzwinel, 2017-03-21 22:53:21]

Description was changed from

==========
Accept but do not apply first autocomplete suggestion in the ClassPaneWidget
when enter is pressed

Now it works like this: http://i.imgur.com/IYk13Yf.gif . Which is consistent
with behaviour in the styles pane.

BUG=690255
==========

to

==========
DevTools: Accept but do not apply first autocomplete suggestion in the
ClassPaneWidget when enter is pressed

Now it works like this: http://i.imgur.com/IYk13Yf.gif . Which is consistent
with behaviour in the styles pane.

BUG=690255
==========

[einbinder, 2017-03-21 23:30:08]

lgtm

https://codereview.chromium.org/2764003002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js (right):

https://codereview.chromium.org/2764003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js:493: var
shouldSelect = !this._disableDefaultSuggestionForEmptyInput || !!this.text();
On 2017/03/21 at 12:32:38, kdzwinel wrote:
> not really related, but I found it while investigating original issue.
`updateSuggestions` expects `shouldSelect` (`selectHighestPriority`) to be a
boolean, before this change it was sometimes a string. BTW: why closure compiler
missed that?
> 
> http://i.imgur.com/XFEzuv4.png

Good catch! I never trust that booleans in devtools are actually booleans. They
are often actually undefined.

[lushnikov, 2017-03-22 00:14:12]

nits:
- could you please wrap description for ~80 chars
- make the issue title be the same as the first line of
  description

lgtm, thanks

[kdzwinel, 2017-03-22 19:21:51]

Description was changed from

==========
DevTools: Accept but do not apply first autocomplete suggestion in the
ClassPaneWidget when enter is pressed

Now it works like this: http://i.imgur.com/IYk13Yf.gif . Which is consistent
with behaviour in the styles pane.

BUG=690255
==========

to

==========
DevTools: Do not apply first suggestion in the classes pane on enter

Now it works like this: http://i.imgur.com/IYk13Yf.gif . Which is consistent
with behaviour in the styles pane.

BUG=690255
==========

[kdzwinel, 2017-03-22 19:22:33]

Description was changed from

==========
DevTools: Do not apply first suggestion in the classes pane on enter

Now it works like this: http://i.imgur.com/IYk13Yf.gif . Which is consistent
with behaviour in the styles pane.

BUG=690255
==========

to

==========
DevTools: Do not apply first suggestion in the classes pane on enter

Now it works like this: http://i.imgur.com/IYk13Yf.gif . 
Which is consistent with the behaviour in the styles pane.

BUG=690255
==========

[kdzwinel, 2017-03-22 19:22:45]

The CQ bit was checked by kdzwinel@gmail.com

[commit-bot: I haz the power, 2017-03-22 19:23:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 21:47:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490210565579020, "parent_rev":
"b24adc5bcbfde7fd67c6b23c3b0721610c77f63b", "commit_rev":
"2ec06ab81aae16ab444938342c2bf0a6fc712374"}

[commit-bot: I haz the power, 2017-03-22 21:49:20]

Description was changed from

==========
DevTools: Do not apply first suggestion in the classes pane on enter

Now it works like this: http://i.imgur.com/IYk13Yf.gif . 
Which is consistent with the behaviour in the styles pane.

BUG=690255
==========

to

==========
DevTools: Do not apply first suggestion in the classes pane on enter

Now it works like this: http://i.imgur.com/IYk13Yf.gif . 
Which is consistent with the behaviour in the styles pane.

BUG=690255

Review-Url: https://codereview.chromium.org/2764003002
Cr-Commit-Position: refs/heads/master@{#458884}
Committed:
https://chromium.googlesource.com/chromium/src/+/2ec06ab81aae16ab444938342c2b...
==========

[commit-bot: I haz the power, 2017-03-22 21:49:21]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2ec06ab81aae16ab444938342c2b...