Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

Issue 2764003002: DevTools: Do not apply first suggestion in the classes pane on enter (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js b/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
index 06160f5a513a7b3de38ae1ffb8a136039d0ed287..6ea5c4771499bd197906f72b4267c00761e4e5b5 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
@@ -490,7 +490,7 @@ UI.TextPrompt = class extends Common.Object {
this._queryRange = new Common.TextRange(
0, beforeRange.toString().length, 0, beforeRange.toString().length + fullWordRange.toString().length);
- var shouldSelect = !this._disableDefaultSuggestionForEmptyInput || this.text();
+ var shouldSelect = !this._disableDefaultSuggestionForEmptyInput || !!this.text();
kdzwinel 2017/03/21 12:32:38 not really related, but I found it while investiga
einbinder 2017/03/21 23:30:08 Good catch! I never trust that booleans in devtool
if (this._suggestBox) {
this._suggestBox.updateSuggestions(
this._boxForAnchorAtStart(selection, fullWordRange), completions, shouldSelect, !this._isCaretAtEndOfPrompt(),
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698