Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2760313003: Revert of Refine the accessibility label of Clear Browsing Data flow. (Closed)

Created:
3 years, 9 months ago by mrefaat
Modified:
3 years, 9 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, srahim+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refine the accessibility label of Clear Browsing Data flow. (patchset #2 id:20001 of https://codereview.chromium.org/2763943002/ ) Reason for revert: Broke History UITestCase.testClearBrowsingHistory https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FEarlGreyiOS%2F25587%2F%2B%2Frecipes%2Fsteps%2Fios_chrome_ui_egtests__iPad_Air_2_iOS_10.0_%2F0%2Flogs%2FHistoryUITestCase.testClearBrowsingHistory%2F0 Original issue's description: > Refine the accessibility label of Clear Browsing Data flow. > > When using VoiceOver, the user taps a button to Clear Browsing Data then > gets on a new Clear Browsing Data button, which can be confusing. > To make it more understandable, this CL changes the accessibility label > of the second button to "Confirm Clear Browsing Data". > > This is a reland of https://codereview.chromium.org/2750403002 > > BUG=688415 > R=lindsayw@chromium.org > > Review-Url: https://codereview.chromium.org/2763943002 > Cr-Commit-Position: refs/heads/master@{#458415} > Committed: https://chromium.googlesource.com/chromium/src/+/145e3d92be1f7d6a82ccaa93e5653efb5115d0f1 TBR=lindsayw@chromium.org,noyau@chromium.org,lpromero@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=688415 Review-Url: https://codereview.chromium.org/2760313003 Cr-Commit-Position: refs/heads/master@{#458481} Committed: https://chromium.googlesource.com/chromium/src/+/0c270621c300c0948fd64b24b7a2907fcf665e48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_egtest.mm View 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mrefaat
Created Revert of Refine the accessibility label of Clear Browsing Data flow.
3 years, 9 months ago (2017-03-21 18:15:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760313003/1
3 years, 9 months ago (2017-03-21 18:15:46 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 9 months ago (2017-03-21 18:15:47 UTC) #5
baxley
lgtm
3 years, 9 months ago (2017-03-21 18:20:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760313003/1
3 years, 9 months ago (2017-03-21 18:22:29 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 18:28:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0c270621c300c0948fd64b24b7a2...

Powered by Google App Engine
This is Rietveld 408576698