Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2763913003: Hide the settings button on a notification in MNC. (Closed)

Created:
3 years, 9 months ago by yhanada
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Hide the settings button on a notification in MNC. BUG=700253 TEST=Check that the settings button shows in NYC and it hides in MNC. Review-Url: https://codereview.chromium.org/2747383002 Cr-Commit-Position: refs/heads/master@{#457688} (cherry picked from commit 24d294391f1a0fce66fa1802d09f9e4a89a94841) Review-Url: https://codereview.chromium.org/2763913003 . Cr-Commit-Position: refs/branch-heads/3029@{#319} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/44c40a2361759cf05a715d76cb5204ddbd55dcfb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -17 lines) Patch
M ui/arc/notification/arc_custom_notification_item.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/arc/notification/arc_custom_notification_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_view.cc View 4 chunks +26 lines, -16 lines 0 comments Download
M ui/arc/notification/arc_notification_item.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/arc/notification/arc_notification_item.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/arc/notification/arc_notification_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/arc/notification/arc_notification_manager.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
yhanada
3 years, 9 months ago (2017-03-21 05:39:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
44c40a2361759cf05a715d76cb5204ddbd55dcfb.

Powered by Google App Engine
This is Rietveld 408576698