Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2747383002: Hide the settings button on a notification in MNC. (Closed)

Created:
3 years, 9 months ago by yhanada
Modified:
3 years, 9 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org, victorhsieh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide the settings button on a notification in MNC. BUG=700253 TEST=Check that the settings button shows in NYC and it hides in MNC. Review-Url: https://codereview.chromium.org/2747383002 Cr-Commit-Position: refs/heads/master@{#457688} Committed: https://chromium.googlesource.com/chromium/src/+/24d294391f1a0fce66fa1802d09f9e4a89a94841

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -17 lines) Patch
M ui/arc/notification/arc_custom_notification_item.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/arc/notification/arc_custom_notification_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_view.cc View 4 chunks +26 lines, -16 lines 0 comments Download
M ui/arc/notification/arc_notification_item.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/arc/notification/arc_notification_item.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/arc/notification/arc_notification_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/arc/notification/arc_notification_manager.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
yhanada
PTAL.
3 years, 9 months ago (2017-03-15 07:33:11 UTC) #4
yhanada
ping?
3 years, 9 months ago (2017-03-17 02:40:37 UTC) #11
yoshiki
lgtm, sorry for delay
3 years, 9 months ago (2017-03-17 04:48:56 UTC) #16
yhanada
No problem. Thank you for reviewing!
3 years, 9 months ago (2017-03-17 04:53:35 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747383002/40001
3 years, 9 months ago (2017-03-17 04:54:09 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 04:59:23 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/24d294391f1a0fce66fa1802d09f...

Powered by Google App Engine
This is Rietveld 408576698