Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2763883002: Revert of Move some basic early process init into Service Manager (Closed)

Created:
3 years, 9 months ago by horo
Modified:
3 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move some basic early process init into Service Manager (patchset #5 id:220001 of https://codereview.chromium.org/2613653003/ ) Reason for revert: Introduced crashes of webkit_tests on Mac. BUG=703465 Original issue's description: > Move some basic early process init into Service Manager > > Introduces the beginnings of an embedder API for the Service Manager, > consisting of a single entry point (service_manager::Main) which in > turn delegates to its embedder for arbitrary initialization and > process execution logic. > > This is the first of several incremental steps to remove content from > the generic process startup flow. Future patches will rework various > main entry points to go through service_manager::Main directly, rather > than going ContentMain -> service_manager::Main. > > This will also allow us to introduce new process types which run the > Service Manager or arbitrary services directly without touching any > part of content. > > BUG=654986 > > Review-Url: https://codereview.chromium.org/2613653003 > Cr-Commit-Position: refs/heads/master@{#458252} > Committed: https://chromium.googlesource.com/chromium/src/+/c6026704ff452d402924ce2d88b0168baf227b1e TBR=jam@chromium.org,rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=654986 Review-Url: https://codereview.chromium.org/2763883002 Cr-Commit-Position: refs/heads/master@{#458278} Committed: https://chromium.googlesource.com/chromium/src/+/1c92dd551abe4a1581981b945076719dff7b4422

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+645 lines, -998 lines) Patch
M build/sanitizers/lsan_suppressions.cc View 1 chunk +60 lines, -62 lines 0 comments Download
M content/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/BUILD.gn View 3 chunks +3 lines, -4 lines 0 comments Download
M content/app/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/app/android/child_process_service_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/app/android/content_main.cc View 3 chunks +12 lines, -14 lines 0 comments Download
M content/app/content_main.cc View 1 chunk +36 lines, -9 lines 0 comments Download
M content/app/content_main_runner.cc View 13 chunks +118 lines, -8 lines 0 comments Download
D content/app/content_service_manager_main_delegate.h View 1 chunk +0 lines, -42 lines 0 comments Download
D content/app/content_service_manager_main_delegate.cc View 1 chunk +0 lines, -45 lines 0 comments Download
A content/app/mac/mac_init.h View 1 chunk +17 lines, -0 lines 0 comments Download
A content/app/mac/mac_init.mm View 1 chunk +25 lines, -0 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/child_process_launcher_helper_posix.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/sandbox_ipc_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M content/common/sandbox_linux/bpf_gpu_policy_linux.cc View 3 chunks +2 lines, -2 lines 0 comments Download
A content/common/set_process_title.h View 1 chunk +27 lines, -0 lines 0 comments Download
A content/common/set_process_title.cc View 1 chunk +95 lines, -0 lines 0 comments Download
A content/common/set_process_title_linux.h View 1 chunk +22 lines, -0 lines 0 comments Download
A content/common/set_process_title_linux.cc View 1 chunk +116 lines, -0 lines 0 comments Download
M content/public/app/content_main.h View 2 chunks +15 lines, -17 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/zygote/zygote_linux.cc View 3 chunks +2 lines, -2 lines 0 comments Download
D services/service_manager/embedder/BUILD.gn View 1 chunk +0 lines, -38 lines 0 comments Download
D services/service_manager/embedder/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D services/service_manager/embedder/README.md View 1 chunk +0 lines, -17 lines 0 comments Download
D services/service_manager/embedder/mac_init.h View 1 chunk +0 lines, -15 lines 0 comments Download
D services/service_manager/embedder/mac_init.mm View 1 chunk +0 lines, -25 lines 0 comments Download
D services/service_manager/embedder/main.h View 1 chunk +0 lines, -33 lines 0 comments Download
D services/service_manager/embedder/main.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D services/service_manager/embedder/main_delegate.h View 1 chunk +0 lines, -50 lines 0 comments Download
D services/service_manager/embedder/service_manager_embedder_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
D services/service_manager/embedder/set_process_title.h View 1 chunk +0 lines, -31 lines 0 comments Download
D services/service_manager/embedder/set_process_title.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D services/service_manager/embedder/set_process_title_linux.h View 1 chunk +0 lines, -22 lines 0 comments Download
D services/service_manager/embedder/set_process_title_linux.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D services/service_manager/embedder/shared_file_util.h View 1 chunk +0 lines, -31 lines 0 comments Download
D services/service_manager/embedder/shared_file_util.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D services/service_manager/embedder/switches.h View 1 chunk +0 lines, -16 lines 0 comments Download
D services/service_manager/embedder/switches.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M services/service_manager/public/cpp/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A services/service_manager/public/cpp/lib/shared_file_util.cc View 1 chunk +49 lines, -0 lines 0 comments Download
A services/service_manager/public/cpp/shared_file_util.h View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
horo
Created Revert of Move some basic early process init into Service Manager
3 years, 9 months ago (2017-03-21 02:04:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763883002/1
3 years, 9 months ago (2017-03-21 02:05:15 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 02:12:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1c92dd551abe4a1581981b945076...

Powered by Google App Engine
This is Rietveld 408576698