Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2613653003: Move some basic early process init into Service Manager (Closed)

Created:
3 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move some basic early process init into Service Manager Introduces the beginnings of an embedder API for the Service Manager, consisting of a single entry point (service_manager::Main) which in turn delegates to its embedder for arbitrary initialization and process execution logic. This is the first of several incremental steps to remove content from the generic process startup flow. Future patches will rework various main entry points to go through service_manager::Main directly, rather than going ContentMain -> service_manager::Main. This will also allow us to introduce new process types which run the Service Manager or arbitrary services directly without touching any part of content. BUG=654986 Review-Url: https://codereview.chromium.org/2613653003 Cr-Original-Commit-Position: refs/heads/master@{#458252} Committed: https://chromium.googlesource.com/chromium/src/+/c6026704ff452d402924ce2d88b0168baf227b1e Review-Url: https://codereview.chromium.org/2613653003 Cr-Commit-Position: refs/heads/master@{#458331} Committed: https://chromium.googlesource.com/chromium/src/+/60d92c2f3ff60c2fcc0b3cddd05738403fb1f0c3

Patch Set 1 : . #

Total comments: 1

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : . #

Total comments: 1

Patch Set 4 : . #

Total comments: 2

Patch Set 5 : . #

Patch Set 6 : fix mac shutdown order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+707 lines, -689 lines) Patch
M build/sanitizers/lsan_suppressions.cc View 1 chunk +80 lines, -78 lines 0 comments Download
M content/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/app/BUILD.gn View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M content/app/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/app/android/child_process_service_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/app/android/content_main.cc View 1 2 3 chunks +14 lines, -12 lines 0 comments Download
M content/app/content_main.cc View 1 2 1 chunk +9 lines, -36 lines 0 comments Download
M content/app/content_main_runner.cc View 1 2 3 4 5 13 chunks +7 lines, -117 lines 0 comments Download
A content/app/content_service_manager_main_delegate.h View 1 2 3 4 1 chunk +42 lines, -0 lines 0 comments Download
A content/app/content_service_manager_main_delegate.cc View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
D content/app/mac/mac_init.h View 1 1 chunk +0 lines, -17 lines 0 comments Download
D content/app/mac/mac_init.mm View 1 1 chunk +0 lines, -25 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/child_process_launcher_helper_posix.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/sandbox_ipc_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 1 2 3 4 5 2 chunks +1 line, -4 lines 0 comments Download
M content/common/sandbox_linux/bpf_gpu_policy_linux.cc View 3 chunks +2 lines, -2 lines 0 comments Download
D content/common/set_process_title.h View 1 chunk +0 lines, -27 lines 0 comments Download
D content/common/set_process_title.cc View 1 chunk +0 lines, -95 lines 0 comments Download
D content/common/set_process_title_linux.h View 1 chunk +0 lines, -22 lines 0 comments Download
D content/common/set_process_title_linux.cc View 1 chunk +0 lines, -116 lines 0 comments Download
M content/public/app/content_main.h View 2 chunks +17 lines, -15 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M content/zygote/zygote_linux.cc View 3 chunks +2 lines, -2 lines 0 comments Download
A services/service_manager/embedder/BUILD.gn View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download
A services/service_manager/embedder/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A services/service_manager/embedder/README.md View 1 chunk +17 lines, -0 lines 0 comments Download
A services/service_manager/embedder/mac_init.h View 1 chunk +15 lines, -0 lines 0 comments Download
A services/service_manager/embedder/mac_init.mm View 1 1 chunk +25 lines, -0 lines 0 comments Download
A services/service_manager/embedder/main.h View 1 chunk +33 lines, -0 lines 0 comments Download
A services/service_manager/embedder/main.cc View 1 2 3 4 5 1 chunk +200 lines, -0 lines 0 comments Download
A services/service_manager/embedder/main_delegate.h View 1 2 1 chunk +50 lines, -0 lines 0 comments Download
A services/service_manager/embedder/service_manager_embedder_export.h View 1 chunk +29 lines, -0 lines 0 comments Download
A + services/service_manager/embedder/set_process_title.h View 2 chunks +9 lines, -5 lines 0 comments Download
A + services/service_manager/embedder/set_process_title.cc View 3 chunks +6 lines, -7 lines 0 comments Download
A + services/service_manager/embedder/set_process_title_linux.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/service_manager/embedder/set_process_title_linux.cc View 4 chunks +5 lines, -5 lines 0 comments Download
A + services/service_manager/embedder/shared_file_util.h View 2 chunks +7 lines, -6 lines 0 comments Download
A + services/service_manager/embedder/shared_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A services/service_manager/embedder/switches.h View 1 chunk +16 lines, -0 lines 0 comments Download
A services/service_manager/embedder/switches.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M services/service_manager/public/cpp/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D services/service_manager/public/cpp/lib/shared_file_util.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D services/service_manager/public/cpp/shared_file_util.h View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 82 (69 generated)
Ken Rockot(use gerrit already)
jam@ could you do an overall review pass and specifically stamp for content ownership? https://codereview.chromium.org/2613653003/diff/80001/build/sanitizers/lsan_suppressions.cc ...
3 years, 9 months ago (2017-03-15 22:11:52 UTC) #38
jam
https://codereview.chromium.org/2613653003/diff/140001/content/app/android/content_main.cc File content/app/android/content_main.cc (right): https://codereview.chromium.org/2613653003/diff/140001/content/app/android/content_main.cc#newcode36 content/app/android/content_main.cc:36: class ContentServiceManagerMainDelegate : public service_manager::MainDelegate { why isn't this ...
3 years, 9 months ago (2017-03-20 15:06:16 UTC) #41
Ken Rockot(use gerrit already)
https://codereview.chromium.org/2613653003/diff/140001/content/app/android/content_main.cc File content/app/android/content_main.cc (right): https://codereview.chromium.org/2613653003/diff/140001/content/app/android/content_main.cc#newcode36 content/app/android/content_main.cc:36: class ContentServiceManagerMainDelegate : public service_manager::MainDelegate { On 2017/03/20 at ...
3 years, 9 months ago (2017-03-20 17:27:06 UTC) #47
jam
lgtm https://codereview.chromium.org/2613653003/diff/200001/content/app/content_service_manager_main_delegate.h File content/app/content_service_manager_main_delegate.h (right): https://codereview.chromium.org/2613653003/diff/200001/content/app/content_service_manager_main_delegate.h#newcode20 content/app/content_service_manager_main_delegate.h:20: class CONTENT_EXPORT ContentServiceManagerMainDelegate are you sure the export ...
3 years, 9 months ago (2017-03-20 22:23:45 UTC) #54
Ken Rockot(use gerrit already)
https://codereview.chromium.org/2613653003/diff/200001/content/app/content_service_manager_main_delegate.h File content/app/content_service_manager_main_delegate.h (right): https://codereview.chromium.org/2613653003/diff/200001/content/app/content_service_manager_main_delegate.h#newcode20 content/app/content_service_manager_main_delegate.h:20: class CONTENT_EXPORT ContentServiceManagerMainDelegate On 2017/03/20 at 22:23:45, jam wrote: ...
3 years, 9 months ago (2017-03-20 22:57:31 UTC) #56
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613653003/220001
3 years, 9 months ago (2017-03-21 00:17:50 UTC) #61
commit-bot: I haz the power
Committed patchset #5 (id:220001) as https://chromium.googlesource.com/chromium/src/+/c6026704ff452d402924ce2d88b0168baf227b1e
3 years, 9 months ago (2017-03-21 00:30:30 UTC) #64
horo
A revert of this CL (patchset #5 id:220001) has been created in https://codereview.chromium.org/2763883002/ by horo@chromium.org. ...
3 years, 9 months ago (2017-03-21 02:04:34 UTC) #65
Ken Rockot(use gerrit already)
On 2017/03/21 at 02:04:34, horo wrote: > A revert of this CL (patchset #5 id:220001) ...
3 years, 9 months ago (2017-03-21 02:07:35 UTC) #66
horo
On 2017/03/21 02:07:35, Ken Rockot wrote: > On 2017/03/21 at 02:04:34, horo wrote: > > ...
3 years, 9 months ago (2017-03-21 02:09:00 UTC) #67
Ken Rockot(use gerrit already)
On 2017/03/21 at 02:09:00, horo wrote: > On 2017/03/21 02:07:35, Ken Rockot wrote: > > ...
3 years, 9 months ago (2017-03-21 05:11:07 UTC) #70
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613653003/240001
3 years, 9 months ago (2017-03-21 06:24:37 UTC) #77
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 06:45:45 UTC) #82
Message was sent while issue was closed.
Committed patchset #6 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/60d92c2f3ff60c2fcc0b3cddd057...

Powered by Google App Engine
This is Rietveld 408576698