Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2763833006: [InputEvent] Add null check before converting Range to StaticRange (Closed)

Created:
3 years, 9 months ago by chongz
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[InputEvent] Add null check before converting Range to StaticRange It's possible for |firstRangeOf()| to return null (see test case), and we shouldn't try to construct StaticRange in this case. BUG=697319 Review-Url: https://codereview.chromium.org/2727293003 Cr-Commit-Position: refs/heads/master@{#454614} (cherry picked from commit b05824d69f2a8403552ef9e29bebdece24005400) Review-Url: https://codereview.chromium.org/2763833006 . Cr-Commit-Position: refs/branch-heads/3029@{#356} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/f79755f945b6cee034ecc5085d7f7ae214251f8f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
A third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-invalid-selection-crash.html View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
chongz
3 years, 9 months ago (2017-03-22 16:01:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f79755f945b6cee034ecc5085d7f7ae214251f8f.

Powered by Google App Engine
This is Rietveld 408576698