[InputEvent] Add null check before converting Range to StaticRange

[InputEvent] Add null check before converting Range to StaticRange

It's possible for |firstRangeOf()| to return null (see test case), and we shouldn't try to
construct StaticRange in this case.

BUG=697319
Review-Url: https://codereview.chromium.org/2727293003
Cr-Commit-Position: refs/heads/master@{#454614}
Committed: https://chromium.googlesource.com/chromium/src/+/b05824d69f2a8403552ef9e29bebdece24005400

[chongz, 2017-03-02 23:06:04]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 23:06:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chongz, 2017-03-02 23:11:58]

Description was changed from

==========
Fix crash caused by invalid range

BUG=697319
==========

to

==========
[InputEvent] Add null check before constructing StaticRange

It's possible for |firstRangeOf()| to return null (see test case), and we
shouldn't try to
construct StaticRange in this case.

BUG=697319
==========

[commit-bot: I haz the power, 2017-03-03 00:36:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 00:36:47]

Dry run: This issue passed the CQ dry run.

[chongz, 2017-03-03 01:55:51]

Description was changed from

==========
[InputEvent] Add null check before constructing StaticRange

It's possible for |firstRangeOf()| to return null (see test case), and we
shouldn't try to
construct StaticRange in this case.

BUG=697319
==========

to

==========
[InputEvent] Add null check before converting Range to StaticRange

It's possible for |firstRangeOf()| to return null (see test case), and we
shouldn't try to
construct StaticRange in this case.

BUG=697319
==========

[chongz, 2017-03-03 01:56:30]

chongz@chromium.org changed reviewers:
+ yosin@chromium.org

[chongz, 2017-03-03 01:56:31]

yosin@ PTAL, thanks!

[yosin_UTC9, 2017-03-03 05:11:50]

lgtm

https://codereview.chromium.org/2727293003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/2727293003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:2075: Range* range =
We would like to do following after this patch:
- Please call updateLayoutIgnoringPendingStyleSheet() before L2703.
- Please use VisibleSelection::firstEphemeralRange()
- Please make StaticRange::create(const EphemeralRange&)

[chongz, 2017-03-03 15:53:50]

https://codereview.chromium.org/2727293003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/2727293003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:2075: Range* range =
On 2017/03/03 05:11:50, yosin_UTC9 wrote:
> We would like to do following after this patch:
> - Please call updateLayoutIgnoringPendingStyleSheet() before L2703.
> - Please use VisibleSelection::firstEphemeralRange()
> - Please make StaticRange::create(const EphemeralRange&)

Sure, will create another patch.

[chongz, 2017-03-03 15:54:01]

The CQ bit was checked by chongz@chromium.org

[commit-bot: I haz the power, 2017-03-03 15:54:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 16:00:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 16:00:48]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[chongz, 2017-03-03 16:22:09]

The CQ bit was checked by chongz@chromium.org

[chongz, 2017-03-03 16:22:10]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2727293003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-03 16:22:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 17:46:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488558129933020,
"parent_rev": "44461dddebd225d5be35ef3e86c4c04cf061fe50", "commit_rev":
"b05824d69f2a8403552ef9e29bebdece24005400"}

[commit-bot: I haz the power, 2017-03-03 17:47:16]

Description was changed from

==========
[InputEvent] Add null check before converting Range to StaticRange

It's possible for |firstRangeOf()| to return null (see test case), and we
shouldn't try to
construct StaticRange in this case.

BUG=697319
==========

to

==========
[InputEvent] Add null check before converting Range to StaticRange

It's possible for |firstRangeOf()| to return null (see test case), and we
shouldn't try to
construct StaticRange in this case.

BUG=697319

Review-Url: https://codereview.chromium.org/2727293003
Cr-Commit-Position: refs/heads/master@{#454614}
Committed:
https://chromium.googlesource.com/chromium/src/+/b05824d69f2a8403552ef9e29beb...
==========

[commit-bot: I haz the power, 2017-03-03 17:47:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b05824d69f2a8403552ef9e29beb...