Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Unified Diff: remoting/client/jni/jni_gl_display_handler.cc

Issue 2763773002: [Remoting Android] Fix race condition when initializing JniDisplayHandler (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/jni/jni_gl_display_handler.cc
diff --git a/remoting/client/jni/jni_gl_display_handler.cc b/remoting/client/jni/jni_gl_display_handler.cc
index 0d3d38482c6a4dbbdaceb7da9e93f424604b62ea..3b511399e4b354c0230d912cb89a46428e725fed 100644
--- a/remoting/client/jni/jni_gl_display_handler.cc
+++ b/remoting/client/jni/jni_gl_display_handler.cc
@@ -83,12 +83,13 @@ JniGlDisplayHandler::Core::Core(base::WeakPtr<JniGlDisplayHandler> shell)
: shell_(shell), weak_factory_(this) {
runtime_ = ChromotingClientRuntime::GetInstance();
DCHECK(!runtime_->display_task_runner()->BelongsToCurrentThread());
+
+ weak_ptr_ = weak_factory_.GetWeakPtr();
+
runtime_->display_task_runner()->PostTask(
FROM_HERE, base::Bind(&JniGlDisplayHandler::Core::Initialize,
base::Unretained(this)));
- weak_ptr_ = weak_factory_.GetWeakPtr();
-
// Do not bind GlRenderer::OnFrameReceived. |renderer_| is not ready yet.
owned_frame_consumer_.reset(new DualBufferFrameConsumer(
base::Bind(&JniGlDisplayHandler::Core::OnFrameReceived, weak_ptr_),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698