Chromium Code Reviews
Descriptiontools/android/loading: rename tracing to tracing_track
There is a "tracing.py" in $SRC/tools/android/loading clashing with a
"tracing/__init__.py" in $CATAPULT/tracing, which makes
android/tools/loading/run_tests FAIL.
Probable cause: https://codereview.chromium.org/2736903005
This was not caught on CQ/bots because the tests are not run
continuously (perhaps they should).
This renaming makes the tests pass.
Note: LoadingTrace objects have the property 'tracing_track' and also
serialization/de-serialization of these objects uses 'tracing_track' as
one of the keys in the dict. The name is not clashing with the module
name and sounds like a good name for what it is doing, hence they should
probably be left unchanged.
BUG=703204
Review-Url: https://codereview.chromium.org/2763733002
Cr-Commit-Position: refs/heads/master@{#458368}
Committed: https://chromium.googlesource.com/chromium/src/+/3dbc3c920c87dec8803e217cc12c8ef286799fab
Patch Set 1 #Patch Set 2 : also rename the unittest #
Messages
Total messages: 13 (7 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||