Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2763733002: tools/android/loading: rename tracing to tracing_track (Closed)

Created:
3 years, 9 months ago by pasko
Modified:
3 years, 9 months ago
Reviewers:
perezju, Benoit L, mattcary
CC:
chromium-reviews, mikecase+watch_chromium.org, gabadie+watch_chromium.org, agrieve+watch_chromium.org, jbudorick+watch_chromium.org, lizeb+watch-android-loading_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/android/loading: rename tracing to tracing_track There is a "tracing.py" in $SRC/tools/android/loading clashing with a "tracing/__init__.py" in $CATAPULT/tracing, which makes android/tools/loading/run_tests FAIL. Probable cause: https://codereview.chromium.org/2736903005 This was not caught on CQ/bots because the tests are not run continuously (perhaps they should). This renaming makes the tests pass. Note: LoadingTrace objects have the property 'tracing_track' and also serialization/de-serialization of these objects uses 'tracing_track' as one of the keys in the dict. The name is not clashing with the module name and sounds like a good name for what it is doing, hence they should probably be left unchanged. BUG=703204 Review-Url: https://codereview.chromium.org/2763733002 Cr-Commit-Position: refs/heads/master@{#458368} Committed: https://chromium.googlesource.com/chromium/src/+/3dbc3c920c87dec8803e217cc12c8ef286799fab

Patch Set 1 #

Patch Set 2 : also rename the unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1100 lines) Patch
M tools/android/loading/activity_lens_unittest.py View 1 chunk +5 lines, -5 lines 0 comments Download
M tools/android/loading/loading_trace.py View 7 chunks +9 lines, -9 lines 0 comments Download
M tools/android/loading/sandwich_metrics.py View 4 chunks +14 lines, -14 lines 0 comments Download
M tools/android/loading/sandwich_metrics_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/android/loading/test_utils.py View 2 chunks +6 lines, -6 lines 0 comments Download
D tools/android/loading/tracing.py View 1 chunk +0 lines, -571 lines 0 comments Download
A + tools/android/loading/tracing_track.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/android/loading/tracing_track_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/android/loading/tracing_unittest.py View 1 1 chunk +0 lines, -493 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
pasko
3 years, 9 months ago (2017-03-20 19:34:07 UTC) #5
mattcary
lgtm
3 years, 9 months ago (2017-03-21 08:50:28 UTC) #6
Benoit L
On 2017/03/21 08:50:28, mattcary wrote: > lgtm lgtm, thanks!
3 years, 9 months ago (2017-03-21 09:21:51 UTC) #7
perezju
lgtm
3 years, 9 months ago (2017-03-21 09:34:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763733002/20001
3 years, 9 months ago (2017-03-21 10:45:50 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 11:00:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3dbc3c920c87dec8803e217cc12c...

Powered by Google App Engine
This is Rietveld 408576698