[Telemetry] Move telemetry from telemetry/timeline/trace_data to tracing/trace_data

[Telemetry] Move telemetry from telemetry/timeline/trace_data to tracing/trace_data

Trace_data was moved to tracing so that other projects, such as systrace, 
that create traces can use it without relying on telemetry as a whole.

BUG=catapult:#3262

Review-Url: https://codereview.chromium.org/2736903005
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/403de21893b7a5d325307ab887f551ef0dcc4a5c

[rnephew (Reviews Here), 2017-03-08 21:25:01]

The CQ bit was checked by rnephew@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 21:25:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rnephew (Reviews Here), 2017-03-08 21:25:37]

Description was changed from

==========
[Telemetry] Move telemetry to from telemetry/timeline/trace_data to
tracing/trace_data

Trace_data was moved to tracing so that other projects, such as systrace, that
create
traces can use it without relying on telemetry as a whole.

BUG=catapult:#3262
==========

to

==========
[Telemetry] Move telemetry from telemetry/timeline/trace_data to
tracing/trace_data

Trace_data was moved to tracing so that other projects, such as systrace, 
that create traces can use it without relying on telemetry as a whole.

BUG=catapult:#3262
==========

[rnephew (Reviews Here), 2017-03-08 21:27:04]

rnephew@chromium.org changed reviewers:
+ charliea@chromium.org, nednguyen@google.com

[rnephew (Reviews Here), 2017-03-08 21:27:05]

https://codereview.chromium.org/2736903005/diff/1/telemetry/telemetry/__init_...
File telemetry/telemetry/__init__.py (right):

https://codereview.chromium.org/2736903005/diff/1/telemetry/telemetry/__init_...
telemetry/telemetry/__init__.py:43: _AddDirToPythonPath(_CATAPULT_DIR,
'third_party', 'vinn')
I was getting import errors when running unittests locally without this.

[commit-bot: I haz the power, 2017-03-08 21:28:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 21:28:37]

Dry run: Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

[nednguyen, 2017-03-08 21:35:27]

lgtm

There may be some clients in chromium/src/ that also use trace_data. So make
sure you check those before removing the module in telemetry

[rnephew (Reviews Here), 2017-03-08 21:40:27]

On 2017/03/08 21:35:27, nednguyen wrote:
> lgtm
> 
> There may be some clients in chromium/src/ that also use trace_data. So make
> sure you check those before removing the module in telemetry

Well this is weird, it passes just find locally but there is an import problem
on the bots.

[rnephew (Reviews Here), 2017-03-08 21:42:20]

The CQ bit was checked by rnephew@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 21:42:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2017-03-08 21:42:58]

On 2017/03/08 21:40:27, rnephew (Reviews Here) wrote:
> On 2017/03/08 21:35:27, nednguyen wrote:
> > lgtm
> > 
> > There may be some clients in chromium/src/ that also use trace_data. So make
> > sure you check those before removing the module in telemetry
> 
> Well this is weird, it passes just find locally but there is an import problem
> on the bots.

hmhh, may have something to do with the stale .pyc file? Either on your machine
or either on the bot

[nednguyen, 2017-03-08 21:44:17]

https://codereview.chromium.org/2736903005/diff/20001/telemetry/telemetry/__i...
File telemetry/telemetry/__init__.py (right):

https://codereview.chromium.org/2736903005/diff/20001/telemetry/telemetry/__i...
telemetry/telemetry/__init__.py:43: _AddDirToPythonPath(_CATAPULT_DIR,
'third_party', 'vinn')
wait, why do you need to include vinn for this change?

[commit-bot: I haz the power, 2017-03-08 21:45:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 21:45:55]

Dry run: Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

[rnephew (Reviews Here), 2017-03-08 21:52:30]

https://codereview.chromium.org/2736903005/diff/20001/telemetry/telemetry/__i...
File telemetry/telemetry/__init__.py (right):

https://codereview.chromium.org/2736903005/diff/20001/telemetry/telemetry/__i...
telemetry/telemetry/__init__.py:43: _AddDirToPythonPath(_CATAPULT_DIR,
'third_party', 'vinn')
On 2017/03/08 21:44:17, nednguyen wrote:
> wait, why do you need to include vinn for this change?

See patchset ones comment. Although I just removed it and reran the tests now
and there is no import error... and the tests keep failing on the waterfall
because of an import error. I think there might be something wrong with python
on my machine right now :/ time for a reboot.

[rnephew (Reviews Here), 2017-03-08 21:53:06]

The CQ bit was checked by rnephew@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 21:53:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 21:56:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 21:56:48]

Dry run: Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

[rnephew (Reviews Here), 2017-03-08 22:22:21]

On 2017/03/08 21:52:30, rnephew (Reviews Here) wrote:
>
https://codereview.chromium.org/2736903005/diff/20001/telemetry/telemetry/__i...
> File telemetry/telemetry/__init__.py (right):
> 
>
https://codereview.chromium.org/2736903005/diff/20001/telemetry/telemetry/__i...
> telemetry/telemetry/__init__.py:43: _AddDirToPythonPath(_CATAPULT_DIR,
> 'third_party', 'vinn')
> On 2017/03/08 21:44:17, nednguyen wrote:
> > wait, why do you need to include vinn for this change?
> 
> See patchset ones comment. Although I just removed it and reran the tests now
> and there is no import error... and the tests keep failing on the waterfall
> because of an import error. I think there might be something wrong with python
> on my machine right now :/ time for a reboot.

Doh, I had __init__.py locally in tracing/trace_data, but it didn't make it into
the other CL. Thats why its passing locally and not on the waterfall.

[rnephew (Reviews Here), 2017-03-08 22:22:41]

The CQ bit was checked by rnephew@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 22:22:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2017-03-08 22:29:53]

On 2017/03/08 22:22:21, rnephew (Reviews Here) wrote:
> On 2017/03/08 21:52:30, rnephew (Reviews Here) wrote:
> >
>
https://codereview.chromium.org/2736903005/diff/20001/telemetry/telemetry/__i...
> > File telemetry/telemetry/__init__.py (right):
> > 
> >
>
https://codereview.chromium.org/2736903005/diff/20001/telemetry/telemetry/__i...
> > telemetry/telemetry/__init__.py:43: _AddDirToPythonPath(_CATAPULT_DIR,
> > 'third_party', 'vinn')
> > On 2017/03/08 21:44:17, nednguyen wrote:
> > > wait, why do you need to include vinn for this change?
> > 
> > See patchset ones comment. Although I just removed it and reran the tests
now
> > and there is no import error... and the tests keep failing on the waterfall
> > because of an import error. I think there might be something wrong with
python
> > on my machine right now :/ time for a reboot.
> 
> Doh, I had __init__.py locally in tracing/trace_data, but it didn't make it
into
> the other CL. Thats why its passing locally and not on the waterfall.

oops

[commit-bot: I haz the power, 2017-03-08 23:08:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 23:08:02]

Dry run: This issue passed the CQ dry run.

[rnephew (Reviews Here), 2017-03-08 23:15:31]

The CQ bit was checked by rnephew@chromium.org

[rnephew (Reviews Here), 2017-03-08 23:15:32]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2736903005/#ps60001
(title: "fix import")

[commit-bot: I haz the power, 2017-03-08 23:15:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 23:18:02]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489014931835690,
"parent_rev": "e91e8745da07fde2034fc38c0a7878c0b05dc106", "commit_rev":
"403de21893b7a5d325307ab887f551ef0dcc4a5c"}

[commit-bot: I haz the power, 2017-03-08 23:18:06]

Description was changed from

==========
[Telemetry] Move telemetry from telemetry/timeline/trace_data to
tracing/trace_data

Trace_data was moved to tracing so that other projects, such as systrace, 
that create traces can use it without relying on telemetry as a whole.

BUG=catapult:#3262
==========

to

==========
[Telemetry] Move telemetry from telemetry/timeline/trace_data to
tracing/trace_data

Trace_data was moved to tracing so that other projects, such as systrace, 
that create traces can use it without relying on telemetry as a whole.

BUG=catapult:#3262

Review-Url: https://codereview.chromium.org/2736903005
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-03-08 23:18:07]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...