Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2763493003: [Extensions Bindings] Make APIBindingsSystemTest reusable (Closed)

Created:
3 years, 9 months ago by Devlin
Modified:
3 years, 9 months ago
Reviewers:
lazyboy, jbroman
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Make APIBindingsSystemTest reusable APIBindingsSystemTest allows the construction of a full APIBindingsSystem (including request/event handlers, constructed API bindings, type reference map, etc), but with custom-made APIs (from a provided JSON spec). This can be useful in testing, since it means we can supply our own bindings and don't have to rely on the "real" ones that the NativeExtensionBindingsSystemUnittest uses. Split api_bindings_system_unittest.cc into a .cc and .h so that we can reuse the test class elsewhere. BUG=653596 Review-Url: https://codereview.chromium.org/2763493003 Cr-Commit-Position: refs/heads/master@{#458262} Committed: https://chromium.googlesource.com/chromium/src/+/34d74089ce961adad864ed974ce27f7bdf270f17

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -102 lines) Patch
M extensions/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A extensions/renderer/api_bindings_system_unittest.h View 1 1 chunk +101 lines, -0 lines 0 comments Download
M extensions/renderer/api_bindings_system_unittest.cc View 2 chunks +81 lines, -102 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Devlin
Sorry in advance for the barrage...
3 years, 9 months ago (2017-03-20 17:53:29 UTC) #6
jbroman
rs lgtm
3 years, 9 months ago (2017-03-20 19:16:27 UTC) #7
lazyboy
lgtm
3 years, 9 months ago (2017-03-20 19:21:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763493003/20001
3 years, 9 months ago (2017-03-20 23:09:02 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 00:54:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/34d74089ce961adad864ed974ce2...

Powered by Google App Engine
This is Rietveld 408576698