|
|
Description[Extensions Bindings] Remove APIBindingsSystemTestWithRealAPI
APIBindingsSystemTestWithRealAPI was a subclass of APIBindingsSystemTest
that used the real backing extension API. Now that we have the
NativeExtensionBindingsSystem and its tests, these are unnecessary and
add clutter. Remove them.
BUG=653596
Review-Url: https://codereview.chromium.org/2753303003
Cr-Commit-Position: refs/heads/master@{#458211}
Committed: https://chromium.googlesource.com/chromium/src/+/ba0370ceeebb5365be73e4673c13c28b0739b737
Patch Set 1 #
Total comments: 2
Patch Set 2 : lazyboy's #Messages
Total messages: 19 (13 generated)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
rdevlin.cronin@chromium.org changed reviewers: + jbroman@chromium.org, lazyboy@chromium.org
Hey folks, mind taking a look?
lgtm
lgtm https://codereview.chromium.org/2753303003/diff/1/extensions/renderer/api_bin... File extensions/renderer/api_bindings_system_unittest.cc (right): https://codereview.chromium.org/2753303003/diff/1/extensions/renderer/api_bin... extensions/renderer/api_bindings_system_unittest.cc:63: " 'parameters': [{ 'name': 'e', '$ref': 'alpha.enumRef'}]" nit: rm space after {
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2753303003/diff/1/extensions/renderer/api_bin... File extensions/renderer/api_bindings_system_unittest.cc (right): https://codereview.chromium.org/2753303003/diff/1/extensions/renderer/api_bin... extensions/renderer/api_bindings_system_unittest.cc:63: " 'parameters': [{ 'name': 'e', '$ref': 'alpha.enumRef'}]" On 2017/03/20 19:24:19, lazyboy wrote: > nit: rm space after { Done.
The CQ bit was checked by rdevlin.cronin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org, jbroman@chromium.org Link to the patchset: https://codereview.chromium.org/2753303003/#ps20001 (title: "lazyboy's")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490047237501600, "parent_rev": "c99c48fc29b8e104b7552cdac7e28f8534c83bb7", "commit_rev": "ba0370ceeebb5365be73e4673c13c28b0739b737"}
Message was sent while issue was closed.
Description was changed from ========== [Extensions Bindings] Remove APIBindingsSystemTestWithRealAPI APIBindingsSystemTestWithRealAPI was a subclass of APIBindingsSystemTest that used the real backing extension API. Now that we have the NativeExtensionBindingsSystem and its tests, these are unnecessary and add clutter. Remove them. BUG=653596 ========== to ========== [Extensions Bindings] Remove APIBindingsSystemTestWithRealAPI APIBindingsSystemTestWithRealAPI was a subclass of APIBindingsSystemTest that used the real backing extension API. Now that we have the NativeExtensionBindingsSystem and its tests, these are unnecessary and add clutter. Remove them. BUG=653596 Review-Url: https://codereview.chromium.org/2753303003 Cr-Commit-Position: refs/heads/master@{#458211} Committed: https://chromium.googlesource.com/chromium/src/+/ba0370ceeebb5365be73e4673c13... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ba0370ceeebb5365be73e4673c13... |