Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2753303003: [Extensions Bindings] Remove APIBindingsSystemTestWithRealAPI (Closed)

Created:
3 years, 9 months ago by Devlin
Modified:
3 years, 9 months ago
Reviewers:
lazyboy, jbroman
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Remove APIBindingsSystemTestWithRealAPI APIBindingsSystemTestWithRealAPI was a subclass of APIBindingsSystemTest that used the real backing extension API. Now that we have the NativeExtensionBindingsSystem and its tests, these are unnecessary and add clutter. Remove them. BUG=653596 Review-Url: https://codereview.chromium.org/2753303003 Cr-Commit-Position: refs/heads/master@{#458211} Committed: https://chromium.googlesource.com/chromium/src/+/ba0370ceeebb5365be73e4673c13c28b0739b737

Patch Set 1 #

Total comments: 2

Patch Set 2 : lazyboy's #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -230 lines) Patch
M extensions/renderer/api_bindings_system_unittest.cc View 1 9 chunks +73 lines, -230 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Devlin
Hey folks, mind taking a look?
3 years, 9 months ago (2017-03-20 16:37:30 UTC) #6
jbroman
lgtm
3 years, 9 months ago (2017-03-20 17:33:02 UTC) #7
lazyboy
lgtm https://codereview.chromium.org/2753303003/diff/1/extensions/renderer/api_bindings_system_unittest.cc File extensions/renderer/api_bindings_system_unittest.cc (right): https://codereview.chromium.org/2753303003/diff/1/extensions/renderer/api_bindings_system_unittest.cc#newcode63 extensions/renderer/api_bindings_system_unittest.cc:63: " 'parameters': [{ 'name': 'e', '$ref': 'alpha.enumRef'}]" nit: ...
3 years, 9 months ago (2017-03-20 19:24:19 UTC) #8
Devlin
https://codereview.chromium.org/2753303003/diff/1/extensions/renderer/api_bindings_system_unittest.cc File extensions/renderer/api_bindings_system_unittest.cc (right): https://codereview.chromium.org/2753303003/diff/1/extensions/renderer/api_bindings_system_unittest.cc#newcode63 extensions/renderer/api_bindings_system_unittest.cc:63: " 'parameters': [{ 'name': 'e', '$ref': 'alpha.enumRef'}]" On 2017/03/20 ...
3 years, 9 months ago (2017-03-20 22:00:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753303003/20001
3 years, 9 months ago (2017-03-20 22:01:19 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 22:48:14 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ba0370ceeebb5365be73e4673c13...

Powered by Google App Engine
This is Rietveld 408576698