Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2763423002: MD Settings: Fix endless recursion when exiting CBD dialog. (Closed)

Created:
3 years, 9 months ago by dpapad
Modified:
3 years, 9 months ago
Reviewers:
tommycli
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix endless recursion when exiting CBD dialog. BUG=703992 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2763423002 Cr-Commit-Position: refs/heads/master@{#458871} Committed: https://chromium.googlesource.com/chromium/src/+/bd09b2036a499ad0be4d31a51898c33d20252878

Patch Set 1 #

Patch Set 2 : Better fix. #

Patch Set 3 : Fix more #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/browser/resources/settings/route.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/main_page_behavior.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/settings/route_tests.js View 1 2 2 chunks +6 lines, -1 line 1 comment Download

Messages

Total messages: 17 (13 generated)
dpapad
https://codereview.chromium.org/2763423002/diff/60001/chrome/test/data/webui/settings/route_tests.js File chrome/test/data/webui/settings/route_tests.js (right): https://codereview.chromium.org/2763423002/diff/60001/chrome/test/data/webui/settings/route_tests.js#newcode109 chrome/test/data/webui/settings/route_tests.js:109: settings.Route.BASIC); I had to update this test too, since ...
3 years, 9 months ago (2017-03-22 20:18:12 UTC) #9
tommycli
perfect lgtm
3 years, 9 months ago (2017-03-22 20:25:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763423002/60001
3 years, 9 months ago (2017-03-22 20:48:13 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 20:56:04 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bd09b2036a499ad0be4d31a51898...

Powered by Google App Engine
This is Rietveld 408576698