Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6999)

Unified Diff: chrome/test/data/webui/settings/route_tests.js

Issue 2763423002: MD Settings: Fix endless recursion when exiting CBD dialog. (Closed)
Patch Set: Fix more Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_page/main_page_behavior.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/route_tests.js
diff --git a/chrome/test/data/webui/settings/route_tests.js b/chrome/test/data/webui/settings/route_tests.js
index 7344683e06fed0b3300a06541bdc34194197abc7..ab0c682e3a658ccae27c3b1087d02f9ff1e0a88e 100644
--- a/chrome/test/data/webui/settings/route_tests.js
+++ b/chrome/test/data/webui/settings/route_tests.js
@@ -106,7 +106,7 @@ suite('route', function() {
return testNavigateBackUsesHistory(
settings.Route.ADVANCED,
settings.Route.PEOPLE,
- settings.Route.ADVANCED);
+ settings.Route.BASIC);
dpapad 2017/03/22 20:18:11 I had to update this test too, since it assumed th
});
test('navigate back to sibling route', function() {
@@ -144,6 +144,11 @@ suite('route', function() {
assertEquals('', settings.getQueryParameters().toString());
});
+ test('navigateTo ADVANCED forwards to BASIC', function() {
+ settings.navigateTo(settings.Route.ADVANCED);
+ assertEquals(settings.Route.BASIC, settings.getCurrentRoute());
+ });
+
test('popstate flag works', function() {
settings.navigateTo(settings.Route.BASIC);
assertFalse(settings.lastRouteChangeWasPopstate());
« no previous file with comments | « chrome/browser/resources/settings/settings_page/main_page_behavior.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698