customtabs: Properly report time from intent to first commit.

customtabs: Properly report time from intent to first commit.

BUG=704168
Review-Url: https://codereview.chromium.org/2763413002
Cr-Commit-Position: refs/heads/master@{#462429}
Committed: https://chromium.googlesource.com/chromium/src/+/4357cb741bf0ae11069184569d1673e55390d079

[Benoit L, 2017-03-22 17:31:37]

lizeb@chromium.org changed reviewers:
+ yusufo@chromium.org

[Yusuf, 2017-03-27 21:40:12]

lgtm

[Benoit L, 2017-03-28 12:15:27]

lizeb@chromium.org changed reviewers:
+ isherman@chromium.org

[Benoit L, 2017-03-28 12:15:27]

+isherman for histograms.xml.
Thanks!

[Ilya Sherman, 2017-03-28 18:14:26]

https://codereview.chromium.org/2763413002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2763413002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:117630: <affected-histogram
name="CustomTabs.IntentToFirstCommitNavigationTime2"/>
Would it be appropriate to stop recording the previous version of this metric?

[Benoit L, 2017-03-31 16:10:24]

Thanks!

https://codereview.chromium.org/2763413002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2763413002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:117630: <affected-histogram
name="CustomTabs.IntentToFirstCommitNavigationTime2"/>
On 2017/03/28 18:14:26, Ilya Sherman wrote:
> Would it be appropriate to stop recording the previous version of this metric?


It is still valuable, with the updated documentation.

[Benoit L, 2017-04-05 15:34:06]

On 2017/03/31 16:10:24, Benoit L wrote:
> Thanks!
> 
>
https://codereview.chromium.org/2763413002/diff/1/tools/metrics/histograms/hi...
> File tools/metrics/histograms/histograms.xml (left):
> 
>
https://codereview.chromium.org/2763413002/diff/1/tools/metrics/histograms/hi...
> tools/metrics/histograms/histograms.xml:117630: <affected-histogram
> name="CustomTabs.IntentToFirstCommitNavigationTime2"/>
> On 2017/03/28 18:14:26, Ilya Sherman wrote:
> > Would it be appropriate to stop recording the previous version of this
metric?
> 
> 
> It is still valuable, with the updated documentation.

ping :-)

[Ilya Sherman, 2017-04-05 23:12:19]

LGTM.  Sorry for losing track of this!

[Benoit L, 2017-04-06 08:23:19]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 08:23:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 09:42:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 09:42:19]

Dry run: This issue passed the CQ dry run.

[Benoit L, 2017-04-06 11:35:58]

The CQ bit was checked by lizeb@chromium.org

[commit-bot: I haz the power, 2017-04-06 11:36:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 11:41:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491478558377130, "parent_rev":
"00a3908827f01ca5cd0bd911a7f12239975bee33", "commit_rev":
"4357cb741bf0ae11069184569d1673e55390d079"}

[commit-bot: I haz the power, 2017-04-06 11:42:02]

Description was changed from

==========
customtabs: Properly report time from intent to first commit.

BUG=704168
==========

to

==========
customtabs: Properly report time from intent to first commit.

BUG=704168

Review-Url: https://codereview.chromium.org/2763413002
Cr-Commit-Position: refs/heads/master@{#462429}
Committed:
https://chromium.googlesource.com/chromium/src/+/4357cb741bf0ae11069184569d16...
==========

[commit-bot: I haz the power, 2017-04-06 11:42:03]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4357cb741bf0ae11069184569d16...