Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2763413002: customtabs: Properly report time from intent to first commit. (Closed)

Created:
3 years, 9 months ago by Benoit L
Modified:
3 years, 8 months ago
Reviewers:
Yusuf, Ilya Sherman
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Properly report time from intent to first commit. BUG=704168 Review-Url: https://codereview.chromium.org/2763413002 Cr-Commit-Position: refs/heads/master@{#462429} Committed: https://chromium.googlesource.com/chromium/src/+/4357cb741bf0ae11069184569d1673e55390d079

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java View 3 chunks +28 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +9 lines, -0 lines 2 comments Download

Messages

Total messages: 18 (9 generated)
Benoit L
3 years, 9 months ago (2017-03-22 17:31:38 UTC) #2
Yusuf
lgtm
3 years, 8 months ago (2017-03-27 21:40:12 UTC) #3
Benoit L
+isherman for histograms.xml. Thanks!
3 years, 8 months ago (2017-03-28 12:15:27 UTC) #5
Ilya Sherman
https://codereview.chromium.org/2763413002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2763413002/diff/1/tools/metrics/histograms/histograms.xml#oldcode117630 tools/metrics/histograms/histograms.xml:117630: <affected-histogram name="CustomTabs.IntentToFirstCommitNavigationTime2"/> Would it be appropriate to stop recording ...
3 years, 8 months ago (2017-03-28 18:14:26 UTC) #6
Benoit L
Thanks! https://codereview.chromium.org/2763413002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2763413002/diff/1/tools/metrics/histograms/histograms.xml#oldcode117630 tools/metrics/histograms/histograms.xml:117630: <affected-histogram name="CustomTabs.IntentToFirstCommitNavigationTime2"/> On 2017/03/28 18:14:26, Ilya Sherman wrote: ...
3 years, 8 months ago (2017-03-31 16:10:24 UTC) #7
Benoit L
On 2017/03/31 16:10:24, Benoit L wrote: > Thanks! > > https://codereview.chromium.org/2763413002/diff/1/tools/metrics/histograms/histograms.xml > File tools/metrics/histograms/histograms.xml (left): ...
3 years, 8 months ago (2017-04-05 15:34:06 UTC) #8
Ilya Sherman
LGTM. Sorry for losing track of this!
3 years, 8 months ago (2017-04-05 23:12:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763413002/1
3 years, 8 months ago (2017-04-06 11:36:11 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 11:42:03 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4357cb741bf0ae11069184569d16...

Powered by Google App Engine
This is Rietveld 408576698