Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1293)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java

Issue 2763413002: customtabs: Properly report time from intent to first commit. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java
index 3268dafec54df4e56c41b8f043f76f8948a6a1c7..02489ed7c29724bf69d235a307bc653683e0f88a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java
@@ -37,6 +37,7 @@ class CustomTabObserver extends EmptyTabObserver {
private long mIntentReceivedTimestamp;
private long mPageLoadStartedTimestamp;
+ private long mFirstCommitTimestamp;
private boolean mScreenshotTakenForCurrentNavigation;
@@ -152,6 +153,22 @@ class CustomTabObserver extends EmptyTabObserver {
RecordHistogram.recordCustomTimesHistogram(histogramPrefix + ".IntentToPageLoadedTime",
timeToPageLoadFinishedMs, 10, TimeUnit.MINUTES.toMillis(10),
TimeUnit.MILLISECONDS, 100);
+
+ // Not all page loads go through a navigation commit (prerender for instance).
+ if (mPageLoadStartedTimestamp != 0) {
+ long timeToFirstCommitMs = mFirstCommitTimestamp - mIntentReceivedTimestamp;
+ // Current median is 550ms, and long tail is very long. ZoomedIn gives good view of
+ // the median and ZoomedOut gives a good overview.
+ RecordHistogram.recordCustomTimesHistogram(
+ "CustomTabs.IntentToFirstCommitNavigationTime3.ZoomedIn",
+ timeToFirstCommitMs, 200, 1000, TimeUnit.MILLISECONDS, 100);
+ // For ZoomedOut very rarely is it under 50ms and this range matches
+ // CustomTabs.IntentToFirstCommitNavigationTime2.ZoomedOut.
+ RecordHistogram.recordCustomTimesHistogram(
+ "CustomTabs.IntentToFirstCommitNavigationTime3.ZoomedOut",
+ timeToFirstCommitMs, 50, TimeUnit.MINUTES.toMillis(10),
+ TimeUnit.MILLISECONDS, 50);
+ }
}
resetPageLoadTracking();
captureNavigationInfo(tab);
@@ -176,6 +193,17 @@ class CustomTabObserver extends EmptyTabObserver {
}
}
+ @Override
+ public void onDidFinishNavigation(Tab tab, String url, boolean isInMainFrame,
+ boolean isErrorPage, boolean hasCommitted, boolean isSameDocument,
+ boolean isFragmentNavigation, Integer pageTransition, int errorCode,
+ int httpStatusCode) {
+ boolean firstNavigation = mFirstCommitTimestamp == 0;
+ boolean isFirstMainFrameCommit = firstNavigation && hasCommitted && !isErrorPage
+ && isInMainFrame && !isSameDocument && !isFragmentNavigation;
+ if (isFirstMainFrameCommit) mFirstCommitTimestamp = SystemClock.elapsedRealtime();
+ }
+
private void resetPageLoadTracking() {
mCurrentState = STATE_RESET;
mIntentReceivedTimestamp = -1;
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698