Added missing case to the switch and removed lint suppression

Added missing case to the switch and removed lint suppression

This CL makes lint happy by handling all possible IntDef values in the switch.

BUG=635567
Review-Url: https://codereview.chromium.org/2763223004
Cr-Commit-Position: refs/heads/master@{#458812}
Committed: https://chromium.googlesource.com/chromium/src/+/6d07ac83d22d93a9b7eee74b2d9a459303108aad

[bsazonov, 2017-03-22 13:03:11]

The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 13:03:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 13:35:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 13:35:54]

Dry run: This issue passed the CQ dry run.

[bsazonov, 2017-03-22 14:38:49]

bsazonov@chromium.org changed reviewers:
+ gogerald@chromium.org

[bsazonov, 2017-03-22 14:38:49]

Ganggui, please take a look.

[gogerald1, 2017-03-22 16:29:50]

lgtm

https://codereview.chromium.org/2763223004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java
(right):

https://codereview.chromium.org/2763223004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java:190:
throw new IllegalStateException("Unknown state: " + mState);
nit: do we need default anymore?

[bsazonov, 2017-03-22 17:46:52]

Thanks, Ganggui.

https://codereview.chromium.org/2763223004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java
(right):

https://codereview.chromium.org/2763223004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java:190:
throw new IllegalStateException("Unknown state: " + mState);
On 2017/03/22 16:29:50, gogerald1 wrote:
> nit: do we need default anymore?

Good point. If we trust in lint - this default is redundant.

[bsazonov, 2017-03-22 17:47:02]

The CQ bit was checked by bsazonov@chromium.org

[bsazonov, 2017-03-22 17:47:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
gogerald@chromium.org
Link to the patchset: https://codereview.chromium.org/2763223004/#ps20001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-03-22 17:47:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 18:29:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490204822772630,
"parent_rev": "337e5e4102234c1dcf1106d701a0e2916329fe7b", "commit_rev":
"6d07ac83d22d93a9b7eee74b2d9a459303108aad"}

[commit-bot: I haz the power, 2017-03-22 18:30:21]

Description was changed from

==========
Added missing case to the switch and removed lint suppression

This CL makes lint happy by handling all possible IntDef values in the switch.

BUG=635567
==========

to

==========
Added missing case to the switch and removed lint suppression

This CL makes lint happy by handling all possible IntDef values in the switch.

BUG=635567

Review-Url: https://codereview.chromium.org/2763223004
Cr-Commit-Position: refs/heads/master@{#458812}
Committed:
https://chromium.googlesource.com/chromium/src/+/6d07ac83d22d93a9b7eee74b2d9a...
==========

[commit-bot: I haz the power, 2017-03-22 18:30:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6d07ac83d22d93a9b7eee74b2d9a...