Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1282)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java

Issue 2763223004: Added missing case to the switch and removed lint suppression (Closed)
Patch Set: Addressed comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java
index 71591b9c5871fdb945e610015a4b216a70a721bf..b545e8177948046899b54b1c531bbdddd8b97f3c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java
@@ -4,7 +4,6 @@
package org.chromium.chrome.browser.signin;
-import android.annotation.SuppressLint;
import android.app.DialogFragment;
import android.app.Fragment;
import android.app.FragmentManager;
@@ -133,8 +132,6 @@ public class ConfirmSyncDataStateMachine
* entire flow is over, if it is answered positively one of the onConfirm functions is called
* and this function is called again.
*/
- // TODO(crbug.com/635567): Fix this properly.
- @SuppressLint("SwitchIntDef")
private void progress() {
switch (mState) {
case BEFORE_OLD_ACCOUNT_DIALOG:
@@ -187,8 +184,8 @@ public class ConfirmSyncDataStateMachine
mState = DONE;
mCallback.onConfirm(mWipeData);
break;
- default:
- assert false : "Invalid state: " + mState;
+ case DONE:
+ throw new IllegalStateException("Can't progress from DONE state!");
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698