DevTools: remove nesting depth tracking from coverage

DevTools: remove nesting depth tracking from coverage

... show "mixed" (half green/half red) block for lines that belong to both
used and unused functions.
Also, remove "unknown" indication and consider everything not explicitly
reported as used to be unused.

BUG=

Review-Url: https://codereview.chromium.org/2763183002
Cr-Commit-Position: refs/heads/master@{#458966}
Committed: https://chromium.googlesource.com/chromium/src/+/b486c36c34f1b6370d65cacc4919c429f65c1dc0

[caseq, 2017-03-21 23:39:46]

Patchset #1 (id:1) has been deleted

[caseq, 2017-03-22 01:33:45]

Patchset #1 (id:20001) has been deleted

[caseq, 2017-03-22 01:37:10]

caseq@chromium.org changed reviewers:
+ alph@chromium.org, pfeldman@chromium.org

[caseq, 2017-03-22 01:37:11]

- remove the notion of depth from coverage internal representation;
- add special rendering for gutter on lines that have both used and unused
ranges;
- made tests more visual;
- (drive by) fixed off-by-one in CSS coverage ranges;

[alph, 2017-03-22 22:30:58]

https://codereview.chromium.org/2763183002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js
(right):

https://codereview.chromium.org/2763183002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js:141: if
(lastLine && lastLine === startLine && lastData !== !!decoration.data()) {
nit: drop "lastLine &&"

[alph, 2017-03-22 22:31:10]

lgtm

[caseq, 2017-03-22 23:49:37]

On 2017/03/22 22:30:58, alph wrote:
>
https://codereview.chromium.org/2763183002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js
> (right):
> 
>
https://codereview.chromium.org/2763183002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js:141: if
> (lastLine && lastLine === startLine && lastData !== !!decoration.data()) {
> nit: drop "lastLine &&"

Nope, it's actually there for a reason :-)

[caseq, 2017-03-22 23:49:42]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2017-03-22 23:50:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 01:15:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490226582504020,
"parent_rev": "54af805eac68ac00ef7a6a9f3ee40fb49894792f", "commit_rev":
"b486c36c34f1b6370d65cacc4919c429f65c1dc0"}

[commit-bot: I haz the power, 2017-03-23 01:15:50]

Description was changed from

==========
DevTools: remove nesting depth tracking from coverage

... show "mixed" (half green/half red) block for lines that belong to both
used and unused functions.
Also, remove "unknown" indication and consider everything not explicitly
reported as used to be unused.

BUG=
==========

to

==========
DevTools: remove nesting depth tracking from coverage

... show "mixed" (half green/half red) block for lines that belong to both
used and unused functions.
Also, remove "unknown" indication and consider everything not explicitly
reported as used to be unused.

BUG=

Review-Url: https://codereview.chromium.org/2763183002
Cr-Commit-Position: refs/heads/master@{#458966}
Committed:
https://chromium.googlesource.com/chromium/src/+/b486c36c34f1b6370d65cacc4919...
==========

[commit-bot: I haz the power, 2017-03-23 01:15:51]

Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b486c36c34f1b6370d65cacc4919...