Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js

Issue 2763183002: DevTools: remove nesting depth tracking from coverage (Closed)
Patch Set: DevTools: remove nesting depth tracking from coverage Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js b/third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js
index 77c48d09308036de7080c6c5b37316dfd0229582..d52c39142251de25ffc365940d564254aa28a51d 100644
--- a/third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js
+++ b/third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js
@@ -133,15 +133,23 @@ Coverage.CoverageView.LineDecorator = class {
return;
textEditor.installGutter(gutterType, false);
-
+ var lastLine = 0;
+ var lastData = undefined;
for (var decoration of decorations) {
- for (var line = decoration.range().startLine; line <= decoration.range().endLine; ++line) {
- var element = createElementWithClass('div');
- if (decoration.data())
- element.className = 'text-editor-coverage-used-marker';
- else
- element.className = 'text-editor-coverage-unused-marker';
-
+ var range = decoration.range();
+ var startLine = range.startLine;
+ if (lastLine && lastLine === startLine && lastData !== !!decoration.data()) {
alph 2017/03/22 22:30:58 nit: drop "lastLine &&"
+ var element = createElementWithClass('div', 'text-editor-coverage-mixed-marker');
+ textEditor.setGutterDecoration(startLine, gutterType, element);
+ startLine++;
+ } else {
+ startLine = Math.max(startLine, lastLine);
+ }
+ lastLine = range.endLine;
+ lastData = !!decoration.data();
+ var className = lastData ? 'text-editor-coverage-used-marker' : 'text-editor-coverage-unused-marker';
+ for (var line = startLine; line <= lastLine; ++line) {
+ var element = createElementWithClass('div', className);
textEditor.setGutterDecoration(line, gutterType, element);
}
}

Powered by Google App Engine
This is Rietveld 408576698