Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 276313002: drive: Change FileCache::GetCacheEntry's return type to FileError (Closed)

Created:
6 years, 7 months ago by hashimoto
Modified:
6 years, 7 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tim+watch_chromium.org, nkostylev+watch_chromium.org, tzik, tfarina, haitaol+watch_chromium.org, nhiroki, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

drive: Change FileCache::GetCacheEntry's return type to FileError To distinguish serious failures from not-found cases. BUG=None TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269757

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -107 lines) Patch
M chrome/browser/chromeos/drive/file_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_cache_unittest.cc View 10 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 3 chunks +13 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation_unittest.cc View 5 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.cc View 3 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/open_file_operation_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_interface.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/remove_stale_cache_files_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer.cc View 4 chunks +13 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc View 11 chunks +12 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client_unittest.cc View 6 chunks +26 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc View 1 chunk +11 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hashimoto
6 years, 7 months ago (2014-05-12 04:39:23 UTC) #1
kinaba
lgtm
6 years, 7 months ago (2014-05-12 06:59:52 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 7 months ago (2014-05-12 07:57:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/276313002/60001
6 years, 7 months ago (2014-05-12 07:57:24 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 09:27:07 UTC) #5
Message was sent while issue was closed. 
Change committed as 269757

Powered by Google App Engine
This is Rietveld 408576698