drive: Change FileCache::GetCacheEntry's return type to FileError

chrome/browser/chromeos/drive/sync_client_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/drive/sync_client.h"
 
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 258 matching lines @@
 
   std::map<std::string, std::string> resource_ids_;  // Name-to-id map.
 };
 
 TEST_F(SyncClientTest, StartProcessingBacklog) {
   sync_client_->StartProcessingBacklog();
   base::RunLoop().RunUntilIdle();
 
   FileCacheEntry cache_entry;
   // Pinned files get downloaded.
-  EXPECT_TRUE(cache_->GetCacheEntry(GetLocalId("foo"), &cache_entry));
+  EXPECT_EQ(FILE_ERROR_OK,
+            cache_->GetCacheEntry(GetLocalId("foo"), &cache_entry));
   EXPECT_TRUE(cache_entry.is_present());
 
-  EXPECT_TRUE(cache_->GetCacheEntry(GetLocalId("bar"), &cache_entry));
+  EXPECT_EQ(FILE_ERROR_OK,
+            cache_->GetCacheEntry(GetLocalId("bar"), &cache_entry));
   EXPECT_TRUE(cache_entry.is_present());
 
-  EXPECT_TRUE(cache_->GetCacheEntry(GetLocalId("baz"), &cache_entry));
+  EXPECT_EQ(FILE_ERROR_OK,
+            cache_->GetCacheEntry(GetLocalId("baz"), &cache_entry));
   EXPECT_TRUE(cache_entry.is_present());
 
   // Dirty file gets uploaded.
-  EXPECT_TRUE(cache_->GetCacheEntry(GetLocalId("dirty"), &cache_entry));
+  EXPECT_EQ(FILE_ERROR_OK,
+            cache_->GetCacheEntry(GetLocalId("dirty"), &cache_entry));
   EXPECT_FALSE(cache_entry.is_dirty());
 
   // Removed entry is not found.
   google_apis::GDataErrorCode status = google_apis::GDATA_OTHER_ERROR;
   scoped_ptr<google_apis::ResourceEntry> resource_entry;
   drive_service_->GetResourceEntry(
       resource_ids_["removed"],
       google_apis::test_util::CreateCopyResultCallback(&status,
                                                        &resource_entry));
   base::RunLoop().RunUntilIdle();
@@ skipping 11 matching lines @@
   EXPECT_EQ(google_apis::HTTP_SUCCESS, status);
   ASSERT_TRUE(resource_entry);
   EXPECT_EQ("moved_new_title", resource_entry->title());
 }
 
 TEST_F(SyncClientTest, AddFetchTask) {
   sync_client_->AddFetchTask(GetLocalId("foo"));
   base::RunLoop().RunUntilIdle();
 
   FileCacheEntry cache_entry;
-  EXPECT_TRUE(cache_->GetCacheEntry(GetLocalId("foo"), &cache_entry));
+  EXPECT_EQ(FILE_ERROR_OK,
+            cache_->GetCacheEntry(GetLocalId("foo"), &cache_entry));
   EXPECT_TRUE(cache_entry.is_present());
 }
 
 TEST_F(SyncClientTest, AddFetchTaskAndCancelled) {
   // Trigger fetching of a file which results in cancellation.
   drive_service_->set_resource_id_to_be_cancelled(resource_ids_["foo"]);
   sync_client_->AddFetchTask(GetLocalId("foo"));
   base::RunLoop().RunUntilIdle();
 
   // The file should be unpinned if the user wants the download to be cancelled.
   FileCacheEntry cache_entry;
-  EXPECT_FALSE(cache_->GetCacheEntry(GetLocalId("foo"), &cache_entry));
+  EXPECT_EQ(FILE_ERROR_NOT_FOUND,
+            cache_->GetCacheEntry(GetLocalId("foo"), &cache_entry));
 }
 
 TEST_F(SyncClientTest, RemoveFetchTask) {
   sync_client_->AddFetchTask(GetLocalId("foo"));
   sync_client_->AddFetchTask(GetLocalId("bar"));
   sync_client_->AddFetchTask(GetLocalId("baz"));
 
   sync_client_->RemoveFetchTask(GetLocalId("foo"));
   sync_client_->RemoveFetchTask(GetLocalId("baz"));
   base::RunLoop().RunUntilIdle();
 
   // Only "bar" should be fetched.
   FileCacheEntry cache_entry;
-  EXPECT_TRUE(cache_->GetCacheEntry(GetLocalId("foo"), &cache_entry));
+  EXPECT_EQ(FILE_ERROR_OK,
+            cache_->GetCacheEntry(GetLocalId("foo"), &cache_entry));
   EXPECT_FALSE(cache_entry.is_present());
 
-  EXPECT_TRUE(cache_->GetCacheEntry(GetLocalId("bar"), &cache_entry));
+  EXPECT_EQ(FILE_ERROR_OK,
+            cache_->GetCacheEntry(GetLocalId("bar"), &cache_entry));
   EXPECT_TRUE(cache_entry.is_present());
 
-  EXPECT_TRUE(cache_->GetCacheEntry(GetLocalId("baz"), &cache_entry));
+  EXPECT_EQ(FILE_ERROR_OK,
+            cache_->GetCacheEntry(GetLocalId("baz"), &cache_entry));
   EXPECT_FALSE(cache_entry.is_present());
 
 }
 
 TEST_F(SyncClientTest, ExistingPinnedFiles) {
   // Start checking the existing pinned files. This will collect the resource
   // IDs of pinned files, with stale local cache files.
   sync_client_->StartCheckingExistingPinnedFiles();
   base::RunLoop().RunUntilIdle();
 
@@ skipping 26 matching lines @@
       TestTimeouts::tiny_timeout());
 
   // Try fetch and upload.
   sync_client_->AddFetchTask(GetLocalId("foo"));
   sync_client_->AddUpdateTask(ClientContext(USER_INITIATED),
                               GetLocalId("dirty"));
   base::RunLoop().RunUntilIdle();
 
   // Not yet fetched nor uploaded.
   FileCacheEntry cache_entry;
-  EXPECT_TRUE(cache_->GetCacheEntry(GetLocalId("foo"), &cache_entry));
+  EXPECT_EQ(FILE_ERROR_OK,
+            cache_->GetCacheEntry(GetLocalId("foo"), &cache_entry));
   EXPECT_FALSE(cache_entry.is_present());
-  EXPECT_TRUE(cache_->GetCacheEntry(GetLocalId("dirty"), &cache_entry));
+  EXPECT_EQ(FILE_ERROR_OK,
+            cache_->GetCacheEntry(GetLocalId("dirty"), &cache_entry));
   EXPECT_TRUE(cache_entry.is_dirty());
 
   // Switch to online.
   fake_network_change_notifier_->SetConnectionType(
       net::NetworkChangeNotifier::CONNECTION_WIFI);
   drive_service_->set_offline(false);
   base::RunLoop().RunUntilIdle();
 
   // Fetched and uploaded.
-  EXPECT_TRUE(cache_->GetCacheEntry(GetLocalId("foo"), &cache_entry));
+  EXPECT_EQ(FILE_ERROR_OK,
+            cache_->GetCacheEntry(GetLocalId("foo"), &cache_entry));
   EXPECT_TRUE(cache_entry.is_present());
-  EXPECT_TRUE(cache_->GetCacheEntry(GetLocalId("dirty"), &cache_entry));
+  EXPECT_EQ(FILE_ERROR_OK,
+            cache_->GetCacheEntry(GetLocalId("dirty"), &cache_entry));
   EXPECT_FALSE(cache_entry.is_dirty());
 }
 
 TEST_F(SyncClientTest, ScheduleRerun) {
   // Add a fetch task for "foo", this should result in being paused.
   drive_service_->set_resource_id_to_be_paused(resource_ids_["foo"]);
   sync_client_->AddFetchTask(GetLocalId("foo"));
   base::RunLoop().RunUntilIdle();
 
   // While the first task is paused, add a task again.
@@ skipping 45 matching lines @@
 
   // Both entries are synced.
   EXPECT_EQ(FILE_ERROR_OK, metadata_->GetResourceEntryById(local_id1, &entry1));
   EXPECT_EQ(ResourceEntry::CLEAN, entry1.metadata_edit_state());
   EXPECT_EQ(FILE_ERROR_OK, metadata_->GetResourceEntryById(local_id2, &entry2));
   EXPECT_EQ(ResourceEntry::CLEAN, entry2.metadata_edit_state());
 }
 
 }  // namespace internal
 }  // namespace drive