chrome/browser/chromeos/drive/file_system/open_file_operation_unittest.cc - Issue 276313002: drive: Change FileCache::GetCacheEntry's return type to FileError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/file_system/open_file_operation_unittest.cc

Issue 276313002: drive: Change FileCache::GetCacheEntry's return type to FileError (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation_unittest.cc ('k') | chrome/browser/chromeos/drive/file_system_interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/drive/file_system/open_file_operation_unittest.cc

diff --git a/chrome/browser/chromeos/drive/file_system/open_file_operation_unittest.cc b/chrome/browser/chromeos/drive/file_system/open_file_operation_unittest.cc

index 734d2a81a2497f76ffe0bc3c2ec1d21e7d5c90b8..a03bb4c031fac84d46ed6dced5184028213ce126 100644

--- a/chrome/browser/chromeos/drive/file_system/open_file_operation_unittest.cc

+++ b/chrome/browser/chromeos/drive/file_system/open_file_operation_unittest.cc

@@ -163,7 +163,6 @@ TEST_F(OpenFileOperationTest, OpenOrCreateExistingFile) {

close_callback.Run();

EXPECT_EQ(1U, observer()->updated_local_ids().count(src_entry.local_id()));

- bool success = false;

FileCacheEntry cache_entry;

base::PostTaskAndReplyWithResult(

blocking_task_runner(),

@@ -172,9 +171,9 @@ TEST_F(OpenFileOperationTest, OpenOrCreateExistingFile) {

base::Unretained(cache()),

src_entry.local_id(),

&cache_entry),

- google_apis::test_util::CreateCopyResultCallback(&success));

+ google_apis::test_util::CreateCopyResultCallback(&error));

test_util::RunBlockingPoolTask();

- EXPECT_TRUE(success);

+ EXPECT_EQ(FILE_ERROR_OK, error);

EXPECT_TRUE(cache_entry.is_present());

EXPECT_TRUE(cache_entry.is_dirty());

}