Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2762853004:
Check WebContentsObservers before showing Previews InfoBars (Closed)
DescriptionCheck WebContentsObservers before showing Previews InfoBars
Check that PreviewsInfoBarTabHelper and InfoBarService are not null
before showing a Previews InfoBar. Don't show the InfoBar if one of
them is null.
BUG=703572
Review-Url: https://codereview.chromium.org/2762853004
Cr-Commit-Position: refs/heads/master@{#458813}
Committed: https://chromium.googlesource.com/chromium/src/+/264c666a260c581a14b69084f1040e633e369eb7
Patch Set 1 #Patch Set 2 : add comment #Patch Set 3 : rebase #Messages
Total messages: 26 (18 generated)
Description was changed from ========== Check PreviewsInfoBarTabHelper and InfoBarService before showing an InfoBar BUG=703572 ========== to ========== Check WebContentsObservers before showing Previews InfoBars Check that PreviewsInfoBarTabHelper and InfoBarService are not null before showing a Previews InfoBar. Don't show the InfoBar if one of them is null. BUG=703572 ==========
The CQ bit was checked by megjablon@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
megjablon@chromium.org changed reviewers: + ryansturm@chromium.org
lgtm % maybe add a comment about why the check is necessary.
The CQ bit was checked by megjablon@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Done
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by megjablon@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity)
The CQ bit was checked by megjablon@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ryansturm@chromium.org Link to the patchset: https://codereview.chromium.org/2762853004/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
The CQ bit was checked by megjablon@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490206452508450,
"parent_rev": "6d07ac83d22d93a9b7eee74b2d9a459303108aad", "commit_rev":
"264c666a260c581a14b69084f1040e633e369eb7"}
Message was sent while issue was closed.
Description was changed from ========== Check WebContentsObservers before showing Previews InfoBars Check that PreviewsInfoBarTabHelper and InfoBarService are not null before showing a Previews InfoBar. Don't show the InfoBar if one of them is null. BUG=703572 ========== to ========== Check WebContentsObservers before showing Previews InfoBars Check that PreviewsInfoBarTabHelper and InfoBarService are not null before showing a Previews InfoBar. Don't show the InfoBar if one of them is null. BUG=703572 Review-Url: https://codereview.chromium.org/2762853004 Cr-Commit-Position: refs/heads/master@{#458813} Committed: https://chromium.googlesource.com/chromium/src/+/264c666a260c581a14b69084f104... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/264c666a260c581a14b69084f104... |
