Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: chrome/browser/previews/previews_infobar_delegate.cc

Issue 2762853004: Check WebContentsObservers before showing Previews InfoBars (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/previews/previews_infobar_delegate.cc
diff --git a/chrome/browser/previews/previews_infobar_delegate.cc b/chrome/browser/previews/previews_infobar_delegate.cc
index 3a34ccddb693d3f087eb995260c839f582692a79..987b4a0a4408d5b5e672ed30bb39e77eb8ff1fad 100644
--- a/chrome/browser/previews/previews_infobar_delegate.cc
+++ b/chrome/browser/previews/previews_infobar_delegate.cc
@@ -59,12 +59,16 @@ void PreviewsInfoBarDelegate::Create(
const OnDismissPreviewsInfobarCallback& on_dismiss_callback) {
PreviewsInfoBarTabHelper* infobar_tab_helper =
PreviewsInfoBarTabHelper::FromWebContents(web_contents);
- if (infobar_tab_helper->displayed_preview_infobar())
- return;
-
InfoBarService* infobar_service =
InfoBarService::FromWebContents(web_contents);
+ // The WebContents may not have TabHelpers set. If TabHelpers are not set,
+ // don't show Previews infobars.
+ if (!infobar_tab_helper || !infobar_service)
+ return;
+ if (infobar_tab_helper->displayed_preview_infobar())
+ return;
+
infobars::InfoBar* infobar =
infobar_service->AddInfoBar(infobar_service->CreateConfirmInfoBar(
std::unique_ptr<ConfirmInfoBarDelegate>(new PreviewsInfoBarDelegate(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698