+harkness for background fetch +tsepez for Mojo callback A test has been included, including a ...
3 years, 9 months ago
(2017-03-20 14:59:22 UTC)
#2
+harkness for background fetch
+tsepez for Mojo callback
A test has been included, including a change detector ASSERT to make sure it's
updated when the BackgroundFetchServiceImpl starts doing something. (On which
I'll definitely CC you, Tom.)
Peter Beverloo
The CQ bit was checked by peter@chromium.org to run a CQ dry run
3 years, 9 months ago
(2017-03-20 15:03:55 UTC)
#3
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1490033123051660, "parent_rev": "6430db2fde6019843ea53e3540757857934b804a", "commit_rev": "da265efafd1b4eca88d17ebd5ec032053fd733bb"}
3 years, 9 months ago
(2017-03-20 18:17:48 UTC)
#11
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490033123051660, "parent_rev":
"6430db2fde6019843ea53e3540757857934b804a", "commit_rev":
"da265efafd1b4eca88d17ebd5ec032053fd733bb"}
commit-bot: I haz the power
Description was changed from ========== BackgroundFetchRegistration.abort() should return a Promise. This aligns our implementation with ...
3 years, 9 months ago
(2017-03-20 18:18:30 UTC)
#12
Message was sent while issue was closed.
Description was changed from
==========
BackgroundFetchRegistration.abort() should return a Promise.
This aligns our implementation with the following change that was pushed
to the specification last week:
https://github.com/WICG/background-fetch/commit/cad906d
"abort() now returns a promise for a boolean"
In addition, it also sets default values on the BackgroundFetchOptions
dictionary which is required to support the fact that it's optional in
the call to BackgroundFetchManager.fetch().
BUG=692534
==========
to
==========
BackgroundFetchRegistration.abort() should return a Promise.
This aligns our implementation with the following change that was pushed
to the specification last week:
https://github.com/WICG/background-fetch/commit/cad906d
"abort() now returns a promise for a boolean"
In addition, it also sets default values on the BackgroundFetchOptions
dictionary which is required to support the fact that it's optional in
the call to BackgroundFetchManager.fetch().
BUG=692534
Review-Url: https://codereview.chromium.org/2762663002
Cr-Commit-Position: refs/heads/master@{#458125}
Committed:
https://chromium.googlesource.com/chromium/src/+/da265efafd1b4eca88d17ebd5ec0...
==========
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/da265efafd1b4eca88d17ebd5ec032053fd733bb
3 years, 9 months ago
(2017-03-20 18:18:32 UTC)
#13
Issue 2762663002: BackgroundFetchRegistration.abort() should return a Promise.
(Closed)
Created 3 years, 9 months ago by Peter Beverloo
Modified 3 years, 9 months ago
Reviewers: harkness, Tom Sepez
Base URL:
Comments: 0