third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.cpp - Issue 2762663002: BackgroundFetchRegistration.abort() should return a Promise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.cpp

Issue 2762663002: BackgroundFetchRegistration.abort() should return a Promise. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.h ('k') | third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.cpp

diff --git a/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.cpp b/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.cpp

index ef89640d0c848985c086ad7795aa43295e7fecae..1c1b63f929da9c6481fc3dbb6befd7b1013401b0 100644

--- a/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.cpp

+++ b/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.cpp

@@ -68,9 +68,10 @@ BackgroundFetchBridge::BackgroundFetchBridge(

BackgroundFetchBridge::~BackgroundFetchBridge() = default;

-void BackgroundFetchBridge::abort(const String& tag) {

+void BackgroundFetchBridge::abort(const String& tag,

+ std::unique_ptr<AbortCallback> callback) {

getService()->Abort(supplementable()->webRegistration()->registrationId(),

- tag);

+ tag, convertToBaseCallback(std::move(callback)));

}

void BackgroundFetchBridge::updateUI(