Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Issue 2762413004: Revert of Revert "Pull AudioDestinationConsumer off the Blink GC heap." (Closed)

Created:
3 years, 9 months ago by sof
Modified:
3 years, 9 months ago
CC:
chromium-reviews, blink-reviews, kinuko+watch, Raymond Toy, tommyw+watchlist_chromium.org, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert "Pull AudioDestinationConsumer off the Blink GC heap." (patchset #1 id:1 of https://codereview.chromium.org/2757883002/ ) Reason for revert: Experiment finished, we do want bb9b04fe09 (cf. https://bugs.chromium.org/p/chromium/issues/detail?id=682945#c48 ) Original issue's description: > Revert "Pull AudioDestinationConsumer off the Blink GC heap." > > This reverts commit bb9b04fe0965eeb09f229f7a727fe7235add810f, > attempting to diagnose root crash cause. > > R=rtoy,haraken > BUG=682945 > > Review-Url: https://codereview.chromium.org/2757883002 > Cr-Commit-Position: refs/heads/master@{#457833} > Committed: https://chromium.googlesource.com/chromium/src/+/937ebc1a2de7ac71ec1de4c6bb1ed7a6331e4683 TBR=haraken@chromium.org,hongchan@chromium.org,rtoy@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=682945 Review-Url: https://codereview.chromium.org/2762413004 Cr-Commit-Position: refs/heads/master@{#458700} Committed: https://chromium.googlesource.com/chromium/src/+/f9428b42fa8f7d0dee29fdc5bcad0d8fd695adc8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -23 lines) Patch
M third_party/WebKit/Source/platform/audio/AudioDestinationConsumer.h View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp View 3 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sof
Created Revert of Revert "Pull AudioDestinationConsumer off the Blink GC heap."
3 years, 9 months ago (2017-03-22 07:19:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762413004/1
3 years, 9 months ago (2017-03-22 07:19:34 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-03-22 07:29:26 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 09:37:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f9428b42fa8f7d0dee29fdc5bcad...

Powered by Google App Engine
This is Rietveld 408576698