Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2757883002: Revert "Pull AudioDestinationConsumer off the Blink GC heap." (Closed)

Created:
3 years, 9 months ago by sof
Modified:
3 years, 9 months ago
CC:
chromium-reviews, blink-reviews, kinuko+watch, Raymond Toy, tommyw+watchlist_chromium.org, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Pull AudioDestinationConsumer off the Blink GC heap." This reverts commit bb9b04fe0965eeb09f229f7a727fe7235add810f, attempting to diagnose root crash cause. R=rtoy,haraken BUG=682945 Review-Url: https://codereview.chromium.org/2757883002 Cr-Commit-Position: refs/heads/master@{#457833} Committed: https://chromium.googlesource.com/chromium/src/+/937ebc1a2de7ac71ec1de4c6bb1ed7a6331e4683

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M third_party/WebKit/Source/platform/audio/AudioDestinationConsumer.h View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp View 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
sof
please take a look. if there's time, i'd like to try to get nearer to ...
3 years, 9 months ago (2017-03-17 14:27:24 UTC) #4
Raymond Toy
lgtm for webaudio
3 years, 9 months ago (2017-03-17 15:19:15 UTC) #5
haraken
LGTM
3 years, 9 months ago (2017-03-17 17:50:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757883002/1
3 years, 9 months ago (2017-03-17 18:46:45 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/937ebc1a2de7ac71ec1de4c6bb1ed7a6331e4683
3 years, 9 months ago (2017-03-17 18:53:35 UTC) #14
sof
3 years, 9 months ago (2017-03-22 07:19:04 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2762413004/ by sigbjornf@opera.com.

The reason for reverting is: Experiment finished, we do want bb9b04fe09 (cf.
https://bugs.chromium.org/p/chromium/issues/detail?id=682945#c48 ).

Powered by Google App Engine
This is Rietveld 408576698