Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2762343003: Revert of Add Android implementation of navigator.getInstalledRelatedApps. (Closed)

Created:
3 years, 9 months ago by horo
Modified:
3 years, 9 months ago
Reviewers:
Matt Giuca, Nico, boliu, dcheng, nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, agrieve+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add Android implementation of navigator.getInstalledRelatedApps. (patchset #21 id:570001 of https://codereview.chromium.org/2706403014/ ) Reason for revert: Introduced compile failure. https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FAndroid%2F70050%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout ../../content/public/android/junit/src/org/chromium/content/browser/installedapp/InstalledAppProviderTest.java:255: error: local variable expectedInstalledRelatedApps is accessed from within inner class; needs to be declared final expectedInstalledRelatedApps.length, installedRelatedApps.length); ^ ../../content/public/android/junit/src/org/chromium/content/browser/installedapp/InstalledAppProviderTest.java:259: error: local variable expectedInstalledRelatedApps is accessed from within inner class; needs to be declared final expectedInstalledRelatedApps[i], installedRelatedApps[i]); Original issue's description: > Add Android implementation of navigator.getInstalledRelatedApps. > > Based on a CL by dhnishi: > https://codereview.chromium.org/1756793004/ > > BUG=587623 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2706403014 > Cr-Commit-Position: refs/heads/master@{#458632} > Committed: https://chromium.googlesource.com/chromium/src/+/8773b38c48cf8b27ed4dd1c8ca249944929d3d16 TBR=thakis@chromium.org,nasko@chromium.org,boliu@chromium.org,dcheng@chromium.org,mgiuca@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=587623 Review-Url: https://codereview.chromium.org/2762343003 Cr-Commit-Position: refs/heads/master@{#458642} Committed: https://chromium.googlesource.com/chromium/src/+/62c02186d3769b4e84cdbcba232fb8ceee6b567f

Patch Set 1 #

Messages

Total messages: 7 (4 generated)
horo
Created Revert of Add Android implementation of navigator.getInstalledRelatedApps.
3 years, 9 months ago (2017-03-22 06:07:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762343003/1
3 years, 9 months ago (2017-03-22 06:08:10 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 06:14:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/62c02186d3769b4e84cdbcba232f...

Powered by Google App Engine
This is Rietveld 408576698